Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1343883003: Fix //content/plugin ax_enums gn build flake (Closed)

Created:
5 years, 3 months ago by tsniatowski
Modified:
5 years, 2 months ago
Reviewers:
ananta, jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix //content/plugin ax_enums gn build flake Flake observerd with target_os="android" and enable_plugins=true: //content/plugin/plugin_thread.cc ends up including the generated ax_enums header so make it depend on it. BUG= Committed: https://crrev.com/d050925ac8f0324186269b1f10c0a8a9d24fab40 Cr-Commit-Position: refs/heads/master@{#348918}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/plugin/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
tsniatowski
PTAL. Either this dep, or a direct dep on //ui/accessibility:ax_gen fixes the flake.
5 years, 3 months ago (2015-09-15 06:35:20 UTC) #2
jam
lgtm
5 years, 3 months ago (2015-09-15 16:28:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343883003/1
5 years, 3 months ago (2015-09-15 16:35:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 17:07:52 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d050925ac8f0324186269b1f10c0a8a9d24fab40 Cr-Commit-Position: refs/heads/master@{#348918}
5 years, 3 months ago (2015-09-15 17:08:23 UTC) #7
Devlin
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1339173003/ by rdevlin.cronin@chromium.org. ...
5 years, 3 months ago (2015-09-15 17:48:02 UTC) #8
tsniatowski
On 2015/09/15 17:48:02, Devlin wrote: > A revert of this CL (patchset #1 id:1) has ...
5 years, 3 months ago (2015-09-15 18:16:28 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 12:46:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d050925ac8f0324186269b1f10c0a8a9d24fab40
Cr-Commit-Position: refs/heads/master@{#348918}

Powered by Google App Engine
This is Rietveld 408576698