Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1339173003: Revert of Fix //content/plugin ax_enums gn build flake (Closed)

Created:
5 years, 3 months ago by Devlin
Modified:
5 years, 3 months ago
Reviewers:
ananta, jam, tsniatowski
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix //content/plugin ax_enums gn build flake (patchset #1 id:1 of https://codereview.chromium.org/1343883003/ ) Reason for revert: This broke Win x64 GN builds: ERROR Dependency cycle: //content:content -> //content/public/plugin:plugin_sources -> //content/plugin:plugin -> //content/public/common:common -> //content:content Original issue's description: > Fix //content/plugin ax_enums gn build flake > > Flake observerd with target_os="android" and enable_plugins=true: > //content/plugin/plugin_thread.cc ends up including the generated > ax_enums header so make it depend on it. > > BUG= > > Committed: https://crrev.com/d050925ac8f0324186269b1f10c0a8a9d24fab40 > Cr-Commit-Position: refs/heads/master@{#348918} TBR=ananta@chromium.org,jam@chromium.org,tsniatowski@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/e30f93f245b69706b6155326a3d78a8999129039 Cr-Commit-Position: refs/heads/master@{#348927}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/plugin/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Devlin
Created Revert of Fix //content/plugin ax_enums gn build flake
5 years, 3 months ago (2015-09-15 17:48:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339173003/1
5 years, 3 months ago (2015-09-15 17:49:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 17:51:33 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e30f93f245b69706b6155326a3d78a8999129039 Cr-Commit-Position: refs/heads/master@{#348927}
5 years, 3 months ago (2015-09-15 17:52:25 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:46:39 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e30f93f245b69706b6155326a3d78a8999129039
Cr-Commit-Position: refs/heads/master@{#348927}

Powered by Google App Engine
This is Rietveld 408576698