[turbofan] Add inlining guards to Runtime_NewArguments.

[turbofan] Add inlining guards to Runtime_NewArguments.

This adds debug code that makes sure that the runtime functions that
materialize arguments objects, {Runtime_New[Sloppy|Strict]Arguments},
are not being called from within an inlined scope. They would produce
wrong results and we should avoid producing code that does this.

R=bmeurer@chromium.org

Committed: https://crrev.com/d0e77b290922fb4f2978d4635e7269447b593e71
Cr-Commit-Position: refs/heads/master@{#30761}

[Benedikt Meurer, 2015-09-16 08:20:55]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2015-09-16 08:20:56]

LGTM with nit

https://codereview.chromium.org/1343763002/diff/1/src/runtime/runtime-scopes.cc
File src/runtime/runtime-scopes.cc (right):

https://codereview.chromium.org/1343763002/diff/1/src/runtime/runtime-scopes....
src/runtime/runtime-scopes.cc:546: // This runtime function does not materialize
the correct arguments when the
Nit: Can we turn this into a helper function on the Frame?

[Michael Starzinger, 2015-09-16 08:32:45]

Patchset #2 (id:20001) has been deleted

[Michael Starzinger, 2015-09-16 10:39:36]

https://codereview.chromium.org/1343763002/diff/1/src/runtime/runtime-scopes.cc
File src/runtime/runtime-scopes.cc (right):

https://codereview.chromium.org/1343763002/diff/1/src/runtime/runtime-scopes....
src/runtime/runtime-scopes.cc:546: // This runtime function does not materialize
the correct arguments when the
On 2015/09/16 08:20:56, Benedikt Meurer wrote:
> Nit: Can we turn this into a helper function on the Frame?

Done. Named it {JavaScriptFrame::HasInlinedFrames}. Note that the implementation
could be optimized but I left it simple for now because we only use it in debug
code for now.

[Michael Starzinger, 2015-09-16 10:47:34]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2015-09-16 10:47:34]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1343763002/#ps40001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2015-09-16 10:47:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1343763002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1343763002/40001

[mvstanton, 2015-09-16 11:15:41]

lgtm

[commit-bot: I haz the power, 2015-09-16 11:32:58]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-09-16 11:33:15]

Patchset 2 (id:??) landed as
https://crrev.com/d0e77b290922fb4f2978d4635e7269447b593e71
Cr-Commit-Position: refs/heads/master@{#30761}