[turbofan] Add inlining guards to Runtime_NewArguments.

src/runtime/runtime-scopes.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/runtime/runtime-utils.h"
 
 #include "src/accessors.h"
 #include "src/arguments.h"
 #include "src/frames-inl.h"
 #include "src/isolate-inl.h"
@@ skipping 524 matching lines @@
              : *NewSloppyArguments(isolate, callee, parameters, argument_count);
 }
 
 
 RUNTIME_FUNCTION(Runtime_NewSloppyArguments) {
   HandleScope scope(isolate);
   DCHECK(args.length() == 3);
   CONVERT_ARG_HANDLE_CHECKED(JSFunction, callee, 0);
   Object** parameters = reinterpret_cast<Object**>(args[1]);
   CONVERT_SMI_ARG_CHECKED(argument_count, 2);
+#ifdef DEBUG
+  // This runtime function does not materialize the correct arguments when the

[Benedikt Meurer, 2015/09/16 08:20:56]

Nit: Can we turn this into a helper function on the Frame?

[Michael Starzinger, 2015/09/16 10:39:36]

Done. Named it {JavaScriptFrame::HasInlinedFrames}. Note that the implementation
could be optimized but I left it simple for now because we only use it in debug
code for now.

+  // caller has been inlined, better make sure we are not hitting that case.
+  List<JSFunction*> functions(1);
+  JavaScriptFrameIterator it(isolate);
+  it.frame()->GetFunctions(&functions);
+  DCHECK_EQ(1, functions.length());
+#endif  // DEBUG
   return *NewSloppyArguments(isolate, callee, parameters, argument_count);
 }
 
 
 RUNTIME_FUNCTION(Runtime_NewStrictArguments) {
   HandleScope scope(isolate);
   DCHECK(args.length() == 3);
   CONVERT_ARG_HANDLE_CHECKED(JSFunction, callee, 0)
   Object** parameters = reinterpret_cast<Object**>(args[1]);
   CONVERT_SMI_ARG_CHECKED(argument_count, 2);
+#ifdef DEBUG
+  // This runtime function does not materialize the correct arguments when the
+  // caller has been inlined, better make sure we are not hitting that case.
+  List<JSFunction*> functions(1);
+  JavaScriptFrameIterator it(isolate);
+  it.frame()->GetFunctions(&functions);
+  DCHECK_EQ(1, functions.length());
+#endif  // DEBUG
   return *NewStrictArguments(isolate, callee, parameters, argument_count);
 }
 
 
 RUNTIME_FUNCTION(Runtime_NewClosure) {
   HandleScope scope(isolate);
   DCHECK_EQ(1, args.length());
   CONVERT_ARG_HANDLE_CHECKED(SharedFunctionInfo, shared, 0);
   Handle<Context> context(isolate->context(), isolate);
   return *isolate->factory()->NewFunctionFromSharedFunctionInfo(shared, context,
@@ skipping 553 matching lines @@
 
   // Lookup in the initial Object.prototype object.
   Handle<Object> result;
   ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
       isolate, result,
       Object::GetProperty(isolate->initial_object_prototype(), key));
   return *result;
 }
 }  // namespace internal
 }  // namespace v8