Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Unified Diff: content/browser/download/download_item_impl.h

Issue 134373003: Return error to chrome.downloads.removeFile (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_item_impl.h
diff --git a/content/browser/download/download_item_impl.h b/content/browser/download/download_item_impl.h
index ada0e36e61c94ca31d70afb6cb9ed962732d32e9..d6dcde0dd59d939539ec20ae10e6de121bd55ed9 100644
--- a/content/browser/download/download_item_impl.h
+++ b/content/browser/download/download_item_impl.h
@@ -129,7 +129,7 @@ class CONTENT_EXPORT DownloadItemImpl
virtual const std::string& GetHash() const OVERRIDE;
virtual const std::string& GetHashState() const OVERRIDE;
virtual bool GetFileExternallyRemoved() const OVERRIDE;
- virtual void DeleteFile() OVERRIDE;
+ virtual void DeleteFile(const base::Callback<void(bool)>& callback) OVERRIDE;
virtual bool IsDangerous() const OVERRIDE;
virtual DownloadDangerType GetDangerType() const OVERRIDE;
virtual bool TimeRemaining(base::TimeDelta* remaining) const OVERRIDE;
@@ -184,7 +184,7 @@ class CONTENT_EXPORT DownloadItemImpl
// Notify observers that this item is being removed by the user.
virtual void NotifyRemoved();
- virtual void OnDownloadedFileRemoved(bool success);
+ virtual void OnDownloadedFileRemoved();
// Provide a weak pointer reference to a DownloadDestinationObserver
// for use by download destinations.
@@ -373,6 +373,8 @@ class CONTENT_EXPORT DownloadItemImpl
void ResumeInterruptedDownload();
+ void DeleteFileDone(const base::Callback<void(bool)>& callback, bool success);
+
static DownloadState InternalToExternalState(
DownloadInternalState internal_state);
static DownloadInternalState ExternalToInternalState(

Powered by Google App Engine
This is Rietveld 408576698