Return error to chrome.downloads.removeFile

chrome/browser/extensions/api/downloads/downloads_api.h

Index: chrome/browser/extensions/api/downloads/downloads_api.h
diff --git a/chrome/browser/extensions/api/downloads/downloads_api.h b/chrome/browser/extensions/api/downloads/downloads_api.h
index 6a9fee9062f3ef35e6643286991aeac6d497b967..80dbd91677df7bb0e8d5dab69d542a3476b8d07f 100644
--- a/chrome/browser/extensions/api/downloads/downloads_api.h
+++ b/chrome/browser/extensions/api/downloads/downloads_api.h
@@ -41,6 +41,7 @@ namespace download_extension_errors {
 // Errors that can be returned through chrome.runtime.lastError.message.
 extern const char kEmptyFile[];
 extern const char kFileAlreadyDeleted[];
+extern const char kFileNotRemoved[];

[asargent_no_longer_on_chrome, 2014/01/14 22:36:04]

nit: Is this constant (or any of the others here) used outside of
downloads_api.cc? If not, then they can just go in an anonymous nameside inside
downloads_api.cc

[benjhayden, 2014/01/16 00:13:24]

Yes, most of them are used in downloads_api_browsertest.cc. The ones that aren't
used there probably should be.

 extern const char kIconNotFound[];
 extern const char kInvalidDangerType[];
 extern const char kInvalidFilename[];
@@ -170,8 +171,7 @@ class DownloadsEraseFunction : public ChromeSyncExtensionFunction {
   DISALLOW_COPY_AND_ASSIGN(DownloadsEraseFunction);
 };
 
-class DownloadsRemoveFileFunction : public ChromeAsyncExtensionFunction,
-                                    public content::DownloadItem::Observer {
+class DownloadsRemoveFileFunction : public ChromeAsyncExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("downloads.removeFile", DOWNLOADS_REMOVEFILE)
   DownloadsRemoveFileFunction();
@@ -181,10 +181,7 @@ class DownloadsRemoveFileFunction : public ChromeAsyncExtensionFunction,
   virtual ~DownloadsRemoveFileFunction();
 
  private:
-  virtual void OnDownloadUpdated(content::DownloadItem* item) OVERRIDE;
-  virtual void OnDownloadDestroyed(content::DownloadItem* item) OVERRIDE;
-
-  content::DownloadItem* item_;
+  void Done(bool success);
 
   DISALLOW_COPY_AND_ASSIGN(DownloadsRemoveFileFunction);
 };