Return error to chrome.downloads.removeFile

chrome/browser/extensions/api/downloads/downloads_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_DOWNLOADS_DOWNLOADS_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_DOWNLOADS_DOWNLOADS_API_H_
 
 #include <set>
 #include <string>
 
@@ skipping 23 matching lines @@
 
 // Functions in the chrome.downloads namespace facilitate
 // controlling downloads from extensions. See the full API doc at
 // http://goo.gl/6hO1n
 
 namespace download_extension_errors {
 
 // Errors that can be returned through chrome.runtime.lastError.message.
 extern const char kEmptyFile[];
 extern const char kFileAlreadyDeleted[];
+extern const char kFileNotRemoved[];

[asargent_no_longer_on_chrome, 2014/01/14 22:36:04]

nit: Is this constant (or any of the others here) used outside of
downloads_api.cc? If not, then they can just go in an anonymous nameside inside
downloads_api.cc

[benjhayden, 2014/01/16 00:13:24]

Yes, most of them are used in downloads_api_browsertest.cc. The ones that aren't
used there probably should be.

 extern const char kIconNotFound[];
 extern const char kInvalidDangerType[];
 extern const char kInvalidFilename[];
 extern const char kInvalidFilter[];
 extern const char kInvalidHeader[];
 extern const char kInvalidId[];
 extern const char kInvalidOrderBy[];
 extern const char kInvalidQueryLimit[];
 extern const char kInvalidState[];
 extern const char kInvalidURL[];
@@ skipping 109 matching lines @@
   DownloadsEraseFunction();
   virtual bool RunImpl() OVERRIDE;
 
  protected:
   virtual ~DownloadsEraseFunction();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(DownloadsEraseFunction);
 };
 
-class DownloadsRemoveFileFunction : public ChromeAsyncExtensionFunction,
-                                    public content::DownloadItem::Observer {
+class DownloadsRemoveFileFunction : public ChromeAsyncExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("downloads.removeFile", DOWNLOADS_REMOVEFILE)
   DownloadsRemoveFileFunction();
   virtual bool RunImpl() OVERRIDE;
 
  protected:
   virtual ~DownloadsRemoveFileFunction();
 
  private:
-  virtual void OnDownloadUpdated(content::DownloadItem* item) OVERRIDE;
-  virtual void OnDownloadDestroyed(content::DownloadItem* item) OVERRIDE;
-
-  content::DownloadItem* item_;
+  void Done(bool success);
 
   DISALLOW_COPY_AND_ASSIGN(DownloadsRemoveFileFunction);
 };
 
 class DownloadsAcceptDangerFunction : public ChromeAsyncExtensionFunction {
  public:
   typedef base::Callback<void(DownloadDangerPrompt*)> OnPromptCreatedCallback;
   static void OnPromptCreatedForTesting(
       OnPromptCreatedCallback* callback) {
     on_prompt_created_ = callback;
@@ skipping 195 matching lines @@
 
   Profile* profile_;
   AllDownloadItemNotifier notifier_;
   std::set<const extensions::Extension*> shelf_disabling_extensions_;
   content::NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionDownloadsEventRouter);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_DOWNLOADS_DOWNLOADS_API_H_