Issue 134353002: Reduce virtual usage in MediaControlElementTypes

Issue 134353002: Reduce virtual usage in MediaControlElementTypes (Closed)

Created:
6 years, 11 months ago by rwlbuis

Modified:
6 years, 11 months ago

Reviewers:
Stephen Chennney, Inactive

CC:
blink-reviews, nessy, philipj_slow, gasubic, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Reduce virtual usage in MediaControlElementTypes mediaController() is not overridden so remove the virtual. isMediaControlElement() can just return true instead of calling a virtual not overridden method. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164902

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add FINAL #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	Source/core/html/shadow/MediaControlElementTypes.h	View	1	3 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/134353002/1

6 years, 11 months ago (2014-01-10 18:53:28 UTC) #3

Inactive

https://codereview.chromium.org/134353002/diff/1/Source/core/html/shadow/MediaControlElementTypes.h File Source/core/html/shadow/MediaControlElementTypes.h (right): https://codereview.chromium.org/134353002/diff/1/Source/core/html/shadow/MediaControlElementTypes.h#newcode108 Source/core/html/shadow/MediaControlElementTypes.h:108: virtual bool isMediaControlElement() const OVERRIDE { return true; } ...

6 years, 11 months ago (2014-01-10 19:03:09 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/134353002/120002

6 years, 11 months ago (2014-01-10 19:11:03 UTC) #5

Message was sent while issue was closed.

Change committed as 164902

Expand Messages | Collapse Messages