Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Unified Diff: Source/core/html/shadow/MediaControlElementTypes.h

Issue 134353002: Reduce virtual usage in MediaControlElementTypes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add FINAL Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/shadow/MediaControlElementTypes.h
diff --git a/Source/core/html/shadow/MediaControlElementTypes.h b/Source/core/html/shadow/MediaControlElementTypes.h
index 19c3ca569e8884f26b15698f6c712ddeb690bbf7..c497c042dd223c0544c9efcb7acb8bb2c20b0d9b 100644
--- a/Source/core/html/shadow/MediaControlElementTypes.h
+++ b/Source/core/html/shadow/MediaControlElementTypes.h
@@ -87,14 +87,13 @@ public:
virtual const AtomicString& shadowPseudoId() const = 0;
virtual void setMediaController(MediaControllerInterface* controller) { m_mediaController = controller; }
- virtual MediaControllerInterface* mediaController() const { return m_mediaController; }
+ MediaControllerInterface* mediaController() const { return m_mediaController; }
protected:
explicit MediaControlElement(MediaControlElementType, HTMLElement*);
~MediaControlElement() { }
virtual void setDisplayType(MediaControlElementType);
- virtual bool isMediaControlElement() const { return true; }
private:
MediaControllerInterface* m_mediaController;
@@ -106,7 +105,7 @@ private:
class MediaControlDivElement : public HTMLDivElement, public MediaControlElement {
protected:
- virtual bool isMediaControlElement() const OVERRIDE { return MediaControlElement::isMediaControlElement(); }
+ virtual bool isMediaControlElement() const OVERRIDE FINAL { return true; }
explicit MediaControlDivElement(Document&, MediaControlElementType);
};
@@ -114,7 +113,7 @@ protected:
class MediaControlInputElement : public HTMLInputElement, public MediaControlElement {
protected:
- virtual bool isMediaControlElement() const OVERRIDE { return MediaControlElement::isMediaControlElement(); }
+ virtual bool isMediaControlElement() const OVERRIDE FINAL { return true; }
explicit MediaControlInputElement(Document&, MediaControlElementType);
private:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698