Fix right-Ctrl mapping menu item.

Fix right-Ctrl mapping menu item.

Previously, the ChromeOS default was set directly on the plugin, bypassing the
DesktopConnectedView where it was being checked for the menu item. Also, unchecking
the menu item would not persist between connections for most users because it results
in an empty set of remappings, which causes the default to be re-applied next time.

BUG=525341

[Jamie, 2015-09-11 21:32:52]

jamiewalch@chromium.org changed reviewers:
+ kelvinp@chromium.org

[Jamie, 2015-09-11 21:32:52]

ptal

[Jamie, 2015-09-14 17:43:15]

ping

[Sergey Ulanov, 2015-09-14 18:01:57]

sergeyu@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Sergey Ulanov, 2015-09-14 18:01:57]

https://codereview.chromium.org/1343503002/diff/1/remoting/webapp/crd/js/desk...
File remoting/webapp/crd/js/desktop_remoting_activity.js (right):

https://codereview.chromium.org/1343503002/diff/1/remoting/webapp/crd/js/desk...
remoting/webapp/crd/js/desktop_remoting_activity.js:98: if
(base.isEmptyObject(remapping) && remoting.platformIsChromeOS()) {
it looks wrong that the remappings list is not allowed to be empty. Maybe set
remoting.Host.Options.remapKeys to null by default and compare it to null here?

[Jamie, 2015-09-15 00:27:01]

https://codereview.chromium.org/1343503002/diff/1/remoting/webapp/crd/js/desk...
File remoting/webapp/crd/js/desktop_remoting_activity.js (right):

https://codereview.chromium.org/1343503002/diff/1/remoting/webapp/crd/js/desk...
remoting/webapp/crd/js/desktop_remoting_activity.js:98: if
(base.isEmptyObject(remapping) && remoting.platformIsChromeOS()) {
On 2015/09/14 18:01:57, Sergey Ulanov wrote:
> it looks wrong that the remappings list is not allowed to be empty. Maybe set
> remoting.Host.Options.remapKeys to null by default and compare it to null
here?

Good idea. It takes quite a lot of refactoring to do that cleanly, but I think
it's a better design. Kelvin, please hold off reviewing for the time being.

[Jamie, 2015-09-25 21:49:45]

On 2015/09/15 00:27:01, Jamie wrote:
>
https://codereview.chromium.org/1343503002/diff/1/remoting/webapp/crd/js/desk...
> File remoting/webapp/crd/js/desktop_remoting_activity.js (right):
> 
>
https://codereview.chromium.org/1343503002/diff/1/remoting/webapp/crd/js/desk...
> remoting/webapp/crd/js/desktop_remoting_activity.js:98: if
> (base.isEmptyObject(remapping) && remoting.platformIsChromeOS()) {
> On 2015/09/14 18:01:57, Sergey Ulanov wrote:
> > it looks wrong that the remappings list is not allowed to be empty. Maybe
set
> > remoting.Host.Options.remapKeys to null by default and compare it to null
> here?
> 
> Good idea. It takes quite a lot of refactoring to do that cleanly, but I think
> it's a better design. Kelvin, please hold off reviewing for the time being.

Fixed by https://codereview.chromium.org/1358173005.