Issue 1343413002: Make `benchmark.mojo` resilient to incorrect trace events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1343413002: Make `benchmark.mojo` resilient to incorrect trace events. (Closed)

Created:
5 years, 3 months ago by ppi

Modified:
5 years, 3 months ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make `benchmark.mojo` resilient to incorrect trace events. This patch majes `benchmark.mojo` print a warning and ignore incorrect events instead of failing hard. The warnings are surfaced in `mojo_benchmark`. Fixes #425. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/447d2f9cbe19366c55e0d192e0378ca95c4bfc56

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -11 lines)			Patch
	M	apps/benchmark/event.cc	View		2 chunks	+12 lines, -10 lines	0 comments	Download
	M	mojo/devtools/common/mojo_benchmark	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ppi

5 years, 3 months ago (2015-09-16 13:57:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
447d2f9cbe19366c55e0d192e0378ca95c4bfc56 (presubmit successful).

Expand Messages | Collapse Messages