mojo/devtools/common/mojo_benchmark - Issue 1343413002: Make `benchmark.mojo` resilient to incorrect trace events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/devtools/common/mojo_benchmark

Issue 1343413002: Make `benchmark.mojo` resilient to incorrect trace events. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/devtools/common/mojo_benchmark

diff --git a/mojo/devtools/common/mojo_benchmark b/mojo/devtools/common/mojo_benchmark

index 756b44ba101f5ec830a4a4397c7cb885b971463c..30fb0571d50a2108d5374bd0a9a622c1e9c89820 100755

--- a/mojo/devtools/common/mojo_benchmark

+++ b/mojo/devtools/common/mojo_benchmark

@@ -89,7 +89,7 @@ def _run_benchmark(shell, shell_args, name, app, duration_seconds, measurements,

# Echo measurement results.

for line in output_lines:

- if line.strip().startswith('measurement:'):

+ if line.strip().startswith('measurement:') or 'WARNING' in line:

print line

return True

« no previous file with comments | « apps/benchmark/event.cc ('k') | no next file » | no next file with comments »