Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: runtime/vm/instructions_arm64.h

Issue 1343373003: Revert "VM: New calling convention for generated code." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/instructions_arm.cc ('k') | runtime/vm/instructions_arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/instructions_arm64.h
diff --git a/runtime/vm/instructions_arm64.h b/runtime/vm/instructions_arm64.h
index 34bc3326d12dc8f6946fdeeb2948114b05e52a66..430be0f169df52a20b1e6bf640b0d2864d13d40d 100644
--- a/runtime/vm/instructions_arm64.h
+++ b/runtime/vm/instructions_arm64.h
@@ -61,14 +61,14 @@ class CallPattern : public ValueObject {
RawICData* IcData();
- RawCode* TargetCode() const;
- void SetTargetCode(const Code& target) const;
+ uword TargetAddress() const;
+ void SetTargetAddress(uword target_address) const;
// This constant length is only valid for inserted call patterns used for
// lazy deoptimization. Regular call pattern may vary in length.
- static const int kDeoptCallLengthInBytes = 5 * Instr::kInstrSize;
+ static const int kLengthInBytes = 5 * Instr::kInstrSize;
- static void InsertDeoptCallAt(uword pc, uword target_address);
+ static void InsertAt(uword pc, uword target_address);
private:
const ObjectPool& object_pool_;
@@ -76,7 +76,7 @@ class CallPattern : public ValueObject {
uword end_;
uword ic_data_load_end_;
- intptr_t target_code_pool_index_;
+ intptr_t target_address_pool_index_;
ICData& ic_data_;
DISALLOW_COPY_AND_ASSIGN(CallPattern);
@@ -87,8 +87,8 @@ class NativeCallPattern : public ValueObject {
public:
NativeCallPattern(uword pc, const Code& code);
- RawCode* target() const;
- void set_target(const Code& target) const;
+ uword target() const;
+ void set_target(uword target_address) const;
NativeFunction native_function() const;
void set_native_function(NativeFunction target) const;
@@ -98,12 +98,33 @@ class NativeCallPattern : public ValueObject {
uword end_;
intptr_t native_function_pool_index_;
- intptr_t target_code_pool_index_;
+ intptr_t target_address_pool_index_;
DISALLOW_COPY_AND_ASSIGN(NativeCallPattern);
};
+class JumpPattern : public ValueObject {
+ public:
+ JumpPattern(uword pc, const Code& code);
+
+ static const int kLengthInBytes = 5 * Instr::kInstrSize;
+
+ int pattern_length_in_bytes() const {
+ return kLengthInBytes;
+ }
+
+ bool IsValid() const;
+ uword TargetAddress() const;
+ void SetTargetAddress(uword target_address) const;
+
+ private:
+ const uword pc_;
+
+ DISALLOW_COPY_AND_ASSIGN(JumpPattern);
+};
+
+
class ReturnPattern : public ValueObject {
public:
explicit ReturnPattern(uword pc);
« no previous file with comments | « runtime/vm/instructions_arm.cc ('k') | runtime/vm/instructions_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698