Don't check URLs against Safe Browsing if not supported.

Don't check URLs against Safe Browsing if not supported.

Default all android builds to safe_browsing=3 mode.

This will fix the crash in chrome_public_apk when built with //clank
checkout.  It'll also provide more consistency between public and private
builds since both will use safe_browsing==3.  At a later
date, the public build will get support for safe browsing.

In a follow-up CL I'd like to disable the Safe Browsing settings UI
when it's not supported, assuming we can determine that before the UI
is created.

BUG=533105
Committed: https://crrev.com/36a226dfc5214fa56583dc14debda373c1718c58
Cr-Commit-Position: refs/heads/master@{#350429}

[Nathan Parker, 2015-09-22 16:16:01]

nparker@chromium.org changed reviewers:
+ mattm@chromium.org, scottmg@chromium.org, thestig@chromium.org

[Nathan Parker, 2015-09-22 16:16:02]

scottmg@chromium.org: Please review changes in 
  common.gypi

thestig@chromium.org: Please review changes in 
  safe_browsing_resource_throttle.cc

mattm: Please review the remainder.  Thanks!

[scottmg, 2015-09-22 17:30:41]

https://codereview.chromium.org/1343293004/diff/20001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1343293004/diff/20001/build/common.gypi#newco...
build/common.gypi:1837: 'safe_browsing%': 3,
don't you need to change build/config/features.gni too?

[Nathan Parker, 2015-09-22 17:54:04]

BTW once this lands, I'll remove the setting in //clank/ supplement.gypi

https://codereview.chromium.org/1343293004/diff/20001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1343293004/diff/20001/build/common.gypi#newco...
build/common.gypi:1837: 'safe_browsing%': 3,
On 2015/09/22 17:30:41, scottmg wrote:
> don't you need to change build/config/features.gni too?

Yes, done.

[scottmg, 2015-09-22 17:58:49]

config files lgtm

https://codereview.chromium.org/1343293004/diff/40001/build/config/features.gni
File build/config/features.gni (right):

https://codereview.chromium.org/1343293004/diff/40001/build/config/features.g...
build/config/features.gni:110: # extended mobile protection via an external API.
 When 3 is fully deployed,
Remove the last sentence?

[Nathan Parker, 2015-09-22 18:22:04]

https://codereview.chromium.org/1343293004/diff/40001/build/config/features.gni
File build/config/features.gni (right):

https://codereview.chromium.org/1343293004/diff/40001/build/config/features.g...
build/config/features.gni:110: # extended mobile protection via an external API.
 When 3 is fully deployed,
On 2015/09/22 17:58:49, scottmg wrote:
> Remove the last sentence?

Done.

[mattm, 2015-09-22 18:42:47]

lgtm

[Lei Zhang, 2015-09-22 20:36:22]

lgtm

https://codereview.chromium.org/1343293004/diff/60001/chrome/browser/renderer...
File chrome/browser/renderer_host/safe_browsing_resource_throttle.cc (right):

https://codereview.chromium.org/1343293004/diff/60001/chrome/browser/renderer...
chrome/browser/renderer_host/safe_browsing_resource_throttle.cc:68: return
nullptr;
nit: wrap this in {} when the if statement is multiple lines.

[Nathan Parker, 2015-09-22 20:40:49]

Thanks for the reviews!

https://codereview.chromium.org/1343293004/diff/60001/chrome/browser/renderer...
File chrome/browser/renderer_host/safe_browsing_resource_throttle.cc (right):

https://codereview.chromium.org/1343293004/diff/60001/chrome/browser/renderer...
chrome/browser/renderer_host/safe_browsing_resource_throttle.cc:68: return
nullptr;
On 2015/09/22 20:36:22, Lei Zhang wrote:
> nit: wrap this in {} when the if statement is multiple lines.

Done.

[Nathan Parker, 2015-09-22 20:40:59]

The CQ bit was checked by nparker@chromium.org

[Nathan Parker, 2015-09-22 20:40:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
scottmg@chromium.org, thestig@chromium.org, mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/1343293004/#ps80001
(title: "braces, per the thestig")

[commit-bot: I haz the power, 2015-09-22 20:42:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1343293004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1343293004/80001

[commit-bot: I haz the power, 2015-09-22 23:10:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-22 23:10:13]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[Nathan Parker, 2015-09-22 23:18:34]

The CQ bit was checked by nparker@chromium.org

[commit-bot: I haz the power, 2015-09-22 23:18:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1343293004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1343293004/80001

[commit-bot: I haz the power, 2015-09-23 04:53:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 04:53:43]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[Nathan Parker, 2015-09-23 17:05:34]

The CQ bit was checked by nparker@chromium.org

[Nathan Parker, 2015-09-23 17:05:52]

The CQ bit was unchecked by nparker@chromium.org

[Nathan Parker, 2015-09-23 21:31:14]

The CQ bit was checked by nparker@chromium.org

[commit-bot: I haz the power, 2015-09-23 21:34:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1343293004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1343293004/80001

[commit-bot: I haz the power, 2015-09-23 21:46:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 21:46:15]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Nathan Parker, 2015-09-23 22:09:44]

The CQ bit was checked by nparker@chromium.org

[commit-bot: I haz the power, 2015-09-23 22:11:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1343293004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1343293004/80001

[commit-bot: I haz the power, 2015-09-23 23:28:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 23:28:27]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Nathan Parker, 2015-09-24 00:33:53]

this fails somewhere different every time.  Still trying.

[Nathan Parker, 2015-09-24 00:36:39]

The CQ bit was checked by nparker@chromium.org

[commit-bot: I haz the power, 2015-09-24 00:38:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1343293004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1343293004/80001

[commit-bot: I haz the power, 2015-09-24 02:30:57]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-09-24 02:31:43]

Patchset 5 (id:??) landed as
https://crrev.com/36a226dfc5214fa56583dc14debda373c1718c58
Cr-Commit-Position: refs/heads/master@{#350429}