chrome/browser/safe_browsing/database_manager.h - Issue 1343293004: Don't check URLs against Safe Browsing if not supported.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/database_manager.h

Issue 1343293004: Don't check URLs against Safe Browsing if not supported. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: braces, per the thestig Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/safe_browsing_resource_throttle.cc ('k') | chrome/browser/safe_browsing/local_database_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/database_manager.h

diff --git a/chrome/browser/safe_browsing/database_manager.h b/chrome/browser/safe_browsing/database_manager.h

index 601d4f3c58064e2596fbafa641d27a43a773af56..f46e2948f3a641af8c3cbb23a223cbe30c2f187f 100644

--- a/chrome/browser/safe_browsing/database_manager.h

+++ b/chrome/browser/safe_browsing/database_manager.h

@@ -43,6 +43,10 @@ class SafeBrowsingDatabaseManager

const std::set<std::string>& threats) {}

};

+ // Returns true if URL-checking is supported on this build+device.

+ // If false, calls to CheckBrowseUrl may dcheck-fail.

+ virtual bool IsSupported() const = 0;

// Returns true if the url's scheme can be checked.

virtual bool CanCheckUrl(const GURL& url) const = 0;