Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1343153003: SkImage-backed SkPictureShader (Closed)

Created:
5 years, 3 months ago by f(malita)
Modified:
5 years, 2 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkImage-backed SkPictureShader Instead of using an explicit image generator + SkBitmap + bitmap shader, switch to the shiny new SkImage/image generator/image shader. R=reed@google.com Committed: https://skia.googlesource.com/skia/+/97be9a0c86eedd8ab85ae7d9aaccb0b0a8e4577d

Patch Set 1 #

Patch Set 2 : minor cleanup #

Patch Set 3 : rough bytesUsed estimate #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M src/core/SkPictureShader.cpp View 1 2 3 2 chunks +17 lines, -11 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343153003/1
5 years, 3 months ago (2015-09-18 17:20:10 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-18 17:26:21 UTC) #4
f(malita)
5 years, 3 months ago (2015-09-18 17:31:07 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343153003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343153003/40001
5 years, 3 months ago (2015-09-18 17:40:26 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/3249) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on ...
5 years, 3 months ago (2015-09-18 17:41:18 UTC) #9
reed1
lgtm Perhaps in the future we can investigate some way to defer the "image" size ...
5 years, 3 months ago (2015-09-18 18:02:36 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343153003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343153003/40001
5 years, 2 months ago (2015-09-25 16:18:18 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/3431) Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on ...
5 years, 2 months ago (2015-09-25 16:19:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343153003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343153003/60001
5 years, 2 months ago (2015-09-25 21:59:49 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/97be9a0c86eedd8ab85ae7d9aaccb0b0a8e4577d
5 years, 2 months ago (2015-09-25 22:04:49 UTC) #18
robertphillips
5 years, 2 months ago (2015-09-28 16:32:31 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1374763003/ by robertphillips@google.com.

The reason for reverting is: This CL appears to be breaking the pictureshader,
pictureshadertile and tiled_picture_shader GMs on the iPad4 and the N7. The
artifact is black rectangles..

Powered by Google App Engine
This is Rietveld 408576698