Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10037)

Unified Diff: chromecast/browser/cast_permission_manager.cc

Issue 1342833002: permissions: handle request ids for permissions in permission manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test failures Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/cast_permission_manager.cc
diff --git a/chromecast/browser/cast_permission_manager.cc b/chromecast/browser/cast_permission_manager.cc
index 047a6ff5a909f0cf85b1b390a77f767a6ab4beae..ac1e3254ba33e4799a1268068bc9329d478e1e1e 100644
--- a/chromecast/browser/cast_permission_manager.cc
+++ b/chromecast/browser/cast_permission_manager.cc
@@ -18,22 +18,18 @@ CastPermissionManager::CastPermissionManager()
CastPermissionManager::~CastPermissionManager() {
}
-void CastPermissionManager::RequestPermission(
+int CastPermissionManager::RequestPermission(
content::PermissionType permission,
content::RenderFrameHost* render_frame_host,
- int request_id,
const GURL& origin,
bool user_gesture,
const base::Callback<void(content::PermissionStatus)>& callback) {
LOG(INFO) << __FUNCTION__ << ": " << static_cast<int>(permission);
callback.Run(content::PermissionStatus::PERMISSION_STATUS_GRANTED);
+ return -1;
mlamouri (slow - plz ping) 2015/09/16 14:42:56 use the constant
Lalit Maganti 2015/09/16 16:41:10 Done.
}
-void CastPermissionManager::CancelPermissionRequest(
- content::PermissionType permission,
- content::RenderFrameHost* render_frame_host,
- int request_id,
- const GURL& origin) {
+void CastPermissionManager::CancelPermissionRequest(int request_id) {
}
void CastPermissionManager::ResetPermission(

Powered by Google App Engine
This is Rietveld 408576698