Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: chromecast/browser/cast_permission_manager.cc

Issue 1342833002: permissions: handle request ids for permissions in permission manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test failures Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromecast/browser/cast_permission_manager.h" 5 #include "chromecast/browser/cast_permission_manager.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "content/public/browser/permission_type.h" 9 #include "content/public/browser/permission_type.h"
10 10
11 namespace chromecast { 11 namespace chromecast {
12 namespace shell { 12 namespace shell {
13 13
14 CastPermissionManager::CastPermissionManager() 14 CastPermissionManager::CastPermissionManager()
15 : content::PermissionManager() { 15 : content::PermissionManager() {
16 } 16 }
17 17
18 CastPermissionManager::~CastPermissionManager() { 18 CastPermissionManager::~CastPermissionManager() {
19 } 19 }
20 20
21 void CastPermissionManager::RequestPermission( 21 int CastPermissionManager::RequestPermission(
22 content::PermissionType permission, 22 content::PermissionType permission,
23 content::RenderFrameHost* render_frame_host, 23 content::RenderFrameHost* render_frame_host,
24 int request_id,
25 const GURL& origin, 24 const GURL& origin,
26 bool user_gesture, 25 bool user_gesture,
27 const base::Callback<void(content::PermissionStatus)>& callback) { 26 const base::Callback<void(content::PermissionStatus)>& callback) {
28 LOG(INFO) << __FUNCTION__ << ": " << static_cast<int>(permission); 27 LOG(INFO) << __FUNCTION__ << ": " << static_cast<int>(permission);
29 callback.Run(content::PermissionStatus::PERMISSION_STATUS_GRANTED); 28 callback.Run(content::PermissionStatus::PERMISSION_STATUS_GRANTED);
29 return -1;
mlamouri (slow - plz ping) 2015/09/16 14:42:56 use the constant
Lalit Maganti 2015/09/16 16:41:10 Done.
30 } 30 }
31 31
32 void CastPermissionManager::CancelPermissionRequest( 32 void CastPermissionManager::CancelPermissionRequest(int request_id) {
33 content::PermissionType permission,
34 content::RenderFrameHost* render_frame_host,
35 int request_id,
36 const GURL& origin) {
37 } 33 }
38 34
39 void CastPermissionManager::ResetPermission( 35 void CastPermissionManager::ResetPermission(
40 content::PermissionType permission, 36 content::PermissionType permission,
41 const GURL& requesting_origin, 37 const GURL& requesting_origin,
42 const GURL& embedding_origin) { 38 const GURL& embedding_origin) {
43 } 39 }
44 40
45 content::PermissionStatus CastPermissionManager::GetPermissionStatus( 41 content::PermissionStatus CastPermissionManager::GetPermissionStatus(
46 content::PermissionType permission, 42 content::PermissionType permission,
(...skipping 16 matching lines...) Expand all
63 const base::Callback<void(content::PermissionStatus)>& callback) { 59 const base::Callback<void(content::PermissionStatus)>& callback) {
64 return -1; 60 return -1;
65 } 61 }
66 62
67 void CastPermissionManager::UnsubscribePermissionStatusChange( 63 void CastPermissionManager::UnsubscribePermissionStatusChange(
68 int subscription_id) { 64 int subscription_id) {
69 } 65 }
70 66
71 } // namespace shell 67 } // namespace shell
72 } // namespace chromecast 68 } // namespace chromecast
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698