Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: content/browser/service_worker/embedded_worker_instance.h

Issue 1342733002: ServiceWorker: log when the script's loaded separately from thread start (chromium) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test fix Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/embedded_worker_instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/embedded_worker_instance.h
diff --git a/content/browser/service_worker/embedded_worker_instance.h b/content/browser/service_worker/embedded_worker_instance.h
index 7bece691cd392a4ebf2b5129611e9a6db8f55a70..edbec815e7ea217577805760e193ce074b1494c9 100644
--- a/content/browser/service_worker/embedded_worker_instance.h
+++ b/content/browser/service_worker/embedded_worker_instance.h
@@ -66,13 +66,14 @@ class CONTENT_EXPORT EmbeddedWorkerInstance {
SCRIPT_DOWNLOADING,
SCRIPT_LOADED,
SCRIPT_EVALUATED,
+ THREAD_STARTED, // Happens after SENT_START_WORKER and before SCRIPT_LOADED
STARTING_PHASE_MAX_VALUE,
};
class Listener {
public:
virtual ~Listener() {}
- virtual void OnScriptLoaded() {}
+ virtual void OnThreadStarted() {}
virtual void OnStarting() {}
virtual void OnStarted() {}
virtual void OnStopping() {}
@@ -187,8 +188,12 @@ class CONTENT_EXPORT EmbeddedWorkerInstance {
void OnReadyForInspection();
// Called back from Registry when the worker instance has ack'ed that
- // it finished loading the script and has started a worker thread.
- void OnScriptLoaded(int thread_id);
+ // it finished loading the script.
+ void OnScriptLoaded();
+
+ // Called back from Registry when the worker instance has ack'ed that
+ // it has started a worker thread.
+ void OnThreadStarted(int thread_id);
// Called back from Registry when the worker instance has ack'ed that
// it failed to load the script.
« no previous file with comments | « no previous file | content/browser/service_worker/embedded_worker_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698