Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: content/browser/service_worker/embedded_worker_instance.cc

Issue 1342733002: ServiceWorker: log when the script's loaded separately from thread start (chromium) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test fix Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_instance.cc
diff --git a/content/browser/service_worker/embedded_worker_instance.cc b/content/browser/service_worker/embedded_worker_instance.cc
index 68e473dcebc15d57c5ee825054bcb4a78ba2ea23..ef03475f8df22ff8bfdf296c1375449e8ec7a0c3 100644
--- a/content/browser/service_worker/embedded_worker_instance.cc
+++ b/content/browser/service_worker/embedded_worker_instance.cc
@@ -366,8 +366,12 @@ void EmbeddedWorkerInstance::OnReadyForInspection() {
devtools_proxy_->NotifyWorkerReadyForInspection();
}
-void EmbeddedWorkerInstance::OnScriptLoaded(int thread_id) {
+void EmbeddedWorkerInstance::OnScriptLoaded() {
starting_phase_ = SCRIPT_LOADED;
+}
+
+void EmbeddedWorkerInstance::OnThreadStarted(int thread_id) {
+ starting_phase_ = THREAD_STARTED;
if (!start_timing_.is_null()) {
if (network_accessed_for_script_) {
UMA_HISTOGRAM_TIMES("EmbeddedWorkerInstance.ScriptLoadWithNetworkAccess",
@@ -382,7 +386,7 @@ void EmbeddedWorkerInstance::OnScriptLoaded(int thread_id) {
start_timing_ = base::TimeTicks::Now();
}
thread_id_ = thread_id;
- FOR_EACH_OBSERVER(Listener, listener_list_, OnScriptLoaded());
+ FOR_EACH_OBSERVER(Listener, listener_list_, OnThreadStarted());
mojo::ServiceProviderPtr exposed_services;
service_registry_->Bind(GetProxy(&exposed_services));
@@ -537,6 +541,8 @@ std::string EmbeddedWorkerInstance::StartingPhaseToString(StartingPhase phase) {
return "Script loaded";
case SCRIPT_EVALUATED:
return "Script evaluated";
+ case THREAD_STARTED:
+ return "Thread started";
case STARTING_PHASE_MAX_VALUE:
NOTREACHED();
}
« no previous file with comments | « content/browser/service_worker/embedded_worker_instance.h ('k') | content/browser/service_worker/embedded_worker_registry.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698