Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 1342673003: Significant refactoring of run_isolated. (Closed)

Created:
5 years, 3 months ago by M-A Ruel
Modified:
5 years, 3 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Base URL:
git@github.com:luci/luci-py.git@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Significant refactoring of run_isolated. Most of the CL is moving code around; Refactor run_isolated to be more readable. The only functional change: Reports all metadata about the child process via json. Change the run_isolated process exit code to only be set when there was an internal failure. This permits clean passing of failure/internal_failure information to task_runner. Update task_runner accordingly. In a follow up, this json file will be used to pass statistics so this can be piped up to the Swarming server. R=vadimsh@chromium.org BUG=https://github.com/luci/luci-py/issues/197 Committed: https://github.com/luci/luci-py/commit/c41a8d02dd69f61e00c74769449cc746b38667f7

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -144 lines) Patch
M appengine/swarming/swarming_bot/bot_code/task_runner.py View 1 chunk +18 lines, -2 lines 0 comments Download
M client/run_isolated.py View 4 chunks +160 lines, -139 lines 0 comments Download
M client/tests/run_isolated_test.py View 1 chunk +8 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
M-A Ruel
5 years, 3 months ago (2015-09-15 13:51:44 UTC) #2
Vadim Sh.
lgtm
5 years, 3 months ago (2015-09-15 17:56:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1342673003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1342673003/20001
5 years, 3 months ago (2015-09-15 18:00:35 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 18:03:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://github.com/luci/luci-py/commit/c41a8d02dd69f61e00c74769449cc746b38667f7

Powered by Google App Engine
This is Rietveld 408576698