Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1337633002: Reapply "Isolated task support in Endpoints API: client side (3/3)" and fixes" (Closed)

Created:
5 years, 3 months ago by M-A Ruel
Modified:
5 years, 3 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Base URL:
git@github.com:luci/luci-py.git@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Reapply "Isolated task support in Endpoints API: client side (3/3)" and fixes" Additional fixes: - Fix shard pending when deduped and decorated. - swarming.py bots was broken. - Updated examples to exercise more code paths. - Removed support for "auto-upload isolated file" in swarming.py trigger. - Renamed Linux to Ubuntu in examples, as Linux is on its way out. R=vadimsh@chromium.org BUG=https://github.com/luci/luci-py/issues/197 Committed: https://github.com/luci/luci-py/commit/d03653b1439f6319b1a37cc9a46adfc2783d7c12

Patch Set 1 : Original patchset as reverted #

Patch Set 2 : We did it, again #

Total comments: 2

Patch Set 3 : Final fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+747 lines, -890 lines) Patch
M appengine/swarming/local_smoke_test.py View 1 3 chunks +91 lines, -0 lines 0 comments Download
A + client/example/2_swarming_run.py View 1 4 chunks +10 lines, -20 lines 0 comments Download
D client/example/2_swarming_run_auto_upload.py View 1 1 chunk +0 lines, -74 lines 0 comments Download
M client/example/3_swarming_trigger_collect.py View 1 4 chunks +15 lines, -20 lines 0 comments Download
M client/example/4_swarming_run_manual_upload.py View 1 chunk +1 line, -1 line 0 comments Download
M client/example/README View 1 1 chunk +1 line, -1 line 0 comments Download
M client/example/common.py View 1 3 chunks +25 lines, -1 line 0 comments Download
M client/example/payload/hello_world.isolate View 1 1 chunk +2 lines, -2 lines 0 comments Download
M client/example/payload/hello_world.py View 1 1 chunk +9 lines, -1 line 0 comments Download
M client/swarming.py View 1 2 37 chunks +330 lines, -323 lines 0 comments Download
M client/tests/swarming_test.py View 1 39 chunks +263 lines, -447 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
M-A Ruel
Patchset #1 and #2 is the delta since the last try. It's quite large (sorry ...
5 years, 3 months ago (2015-09-14 15:51:20 UTC) #2
Vadim Sh.
lgtm with nit https://codereview.chromium.org/1337633002/diff/40001/client/swarming.py File client/swarming.py (right): https://codereview.chromium.org/1337633002/diff/40001/client/swarming.py#newcode226 client/swarming.py:226: env.append({'key': 'GTEST_SHARD_INDEX', 'value': str(index)}) nit: override ...
5 years, 3 months ago (2015-09-14 17:46:52 UTC) #3
M-A Ruel
https://codereview.chromium.org/1337633002/diff/40001/client/swarming.py File client/swarming.py (right): https://codereview.chromium.org/1337633002/diff/40001/client/swarming.py#newcode226 client/swarming.py:226: env.append({'key': 'GTEST_SHARD_INDEX', 'value': str(index)}) On 2015/09/14 17:46:52, Vadim Sh. ...
5 years, 3 months ago (2015-09-15 14:13:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337633002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337633002/80001
5 years, 3 months ago (2015-09-15 19:33:01 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 19:35:25 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://github.com/luci/luci-py/commit/d03653b1439f6319b1a37cc9a46adfc2783d7c12

Powered by Google App Engine
This is Rietveld 408576698