Source/core/svg/SVGUseElement.h - Issue 134263003: Followup fixes for bug 332066.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGUseElement.h

Issue 134263003: Followup fixes for bug 332066. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: setTimeout == race with load Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/svg/custom/loadevents-async.html ('K') | « Source/core/svg/SVGDocumentExtensions.cpp ('k') | Source/core/svg/SVGUseElement.cpp » ('j') | Source/core/svg/SVGUseElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/svg/SVGUseElement.h

diff --git a/Source/core/svg/SVGUseElement.h b/Source/core/svg/SVGUseElement.h

index b83af14014f1ded326dfc7bf7d63a8311fb5f8e2..64ef9e714e27ff20abbf89609cc2aafc3de397c1 100644

--- a/Source/core/svg/SVGUseElement.h

+++ b/Source/core/svg/SVGUseElement.h

@@ -57,7 +57,8 @@ private:

SVGUseElement(Document&, bool wasInsertedByParser);

virtual bool isValid() const OVERRIDE { return SVGTests::isValid(); }

- virtual bool isStructurallyExternal() const OVERRIDE { return isExternalURIReference(hrefCurrentValue(), document()); }

+ virtual bool isStructurallyExternal() const OVERRIDE { return !hrefCurrentValue().isNull() && isExternalURIReference(hrefCurrentValue(), document()); }

virtual bool supportsFocus() const OVERRIDE { return hasFocusEventListeners(); }

virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE;

@@ -78,7 +79,7 @@ private:

void buildShadowAndInstanceTree(SVGElement* target);

void detachInstance();

- virtual bool haveLoadedRequiredResources() OVERRIDE { return m_haveFiredLoadEvent; }

+ virtual bool haveLoadedRequiredResources() OVERRIDE { return !isStructurallyExternal() || m_haveFiredLoadEvent; }

virtual void finishParsingChildren() OVERRIDE;

virtual bool selfHasRelativeLengths() const OVERRIDE;

« LayoutTests/svg/custom/loadevents-async.html ('K') | « Source/core/svg/SVGDocumentExtensions.cpp ('k') | Source/core/svg/SVGUseElement.cpp » ('j') | Source/core/svg/SVGUseElement.cpp » ('J')