LayoutTests/svg/custom/loadevents-async.html - Issue 134263003: Followup fixes for bug 332066.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/svg/custom/loadevents-async.html

Issue 134263003: Followup fixes for bug 332066. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: setTimeout == race with load Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/svg/custom/loadevents-async.html

diff --git a/LayoutTests/svg/custom/loadevents-async.html b/LayoutTests/svg/custom/loadevents-async.html

index e624e902ca45a29871b0077bc84e1b73ee860701..f6c8fd966b4122b37a24d156690b575bef815563 100644

--- a/LayoutTests/svg/custom/loadevents-async.html

+++ b/LayoutTests/svg/custom/loadevents-async.html

@@ -14,17 +14,20 @@ var emptyDocument = document.implementation.createDocument("", "", null);

document.body.appendChild(spanElement);

divElement.appendChild(useElement);

-useElement.addEventListener("load", function () { emptyDocument.adoptNode(useElement); invoked = true; }, false);

+useElement.addEventListener("load", function () {

+ emptyDocument.adoptNode(useElement);

+ invoked = true;

+ shouldBeTrue("invoked");

Stephen Chennney 2014/01/13 17:24:17 This seems pointless. Is there some other sensible

Erik Dahlström (inactive) 2014/01/14 09:03:59 Done.

+ finishJSTest();

+ }, false);

spanElement.appendChild(divElement);

document.body.appendChild(useElement);

shouldBeFalse("invoked");

jsTestIsAsync = true;

-setTimeout(function() {

- shouldBeTrue("invoked");

- finishJSTest();

-}, 1);

+// need to reference an external file to get a load event

+useElement.setAttributeNS("http://www.w3.org/1999/xlink", "xlink:href", "resources/rgb.svg#RGB");

</script>

<body>

</html>