Followup fixes for bug 332066.

Followup fixes for bug 332066.

* <use> elements only dispatch load if there's an external resource,
  adjust tests accordingly.
* <use> incorrectly reported that it wasn't done if there was no
  xlink:href attribute.
* don't dispatch 'load' to svg documents that are not xml-wellformed.

BUG=333242
R=pdr@chromium.org, schenney@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165413

[Erik Dahlström (inactive), 2014-01-13 11:55:21]

These are some followup fixes for the externalResourcesRequired removal. In
particular this refers to how load events are triggered on <use> elements and on
the root svg.

It should hopefully fix the the svg test flakiness issues reported on blink-dev.

[Stephen Chennney, 2014-01-13 17:24:16]

LGTM

Just one nit. Looks like the try bot failures are not your fault in any way.

https://codereview.chromium.org/134263003/diff/140001/LayoutTests/svg/custom/...
File LayoutTests/svg/custom/loadevents-async.html (right):

https://codereview.chromium.org/134263003/diff/140001/LayoutTests/svg/custom/...
LayoutTests/svg/custom/loadevents-async.html:20: shouldBeTrue("invoked");
This seems pointless. Is there some other sensible test? Otherwise just remove
it.

[pdr., 2014-01-13 19:56:37]

LGTM2

https://codereview.chromium.org/134263003/diff/140001/Source/core/svg/SVGUseE...
File Source/core/svg/SVGUseElement.cpp (right):

https://codereview.chromium.org/134263003/diff/140001/Source/core/svg/SVGUseE...
Source/core/svg/SVGUseElement.cpp:970: instanceTreeIsLoading(instance);
Wow. Spot the bug :)

(I'll fix this in a separate patch)

[Erik Dahlström (inactive), 2014-01-14 09:03:58]

https://codereview.chromium.org/134263003/diff/140001/LayoutTests/svg/custom/...
File LayoutTests/svg/custom/loadevents-async.html (right):

https://codereview.chromium.org/134263003/diff/140001/LayoutTests/svg/custom/...
LayoutTests/svg/custom/loadevents-async.html:20: shouldBeTrue("invoked");
On 2014/01/13 17:24:17, Stephen Chenney wrote:
> This seems pointless. Is there some other sensible test? Otherwise just remove
> it.

Done.

[commit-bot: I haz the power, 2014-01-14 09:05:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ed@opera.com/134263003/280001

[commit-bot: I haz the power, 2014-01-14 12:18:05]

Retried try job too often on linux_blink for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-14 13:39:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ed@opera.com/134263003/280001

[commit-bot: I haz the power, 2014-01-14 17:00:29]

Retried try job too often on linux_blink for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-15 00:12:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ed@opera.com/134263003/280001

[commit-bot: I haz the power, 2014-01-15 13:46:04]

Retried try job too often on linux_blink for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-16 15:17:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ed@opera.com/134263003/280001

[commit-bot: I haz the power, 2014-01-16 15:17:07]

Failed to apply patch for Source/core/svg/SVGUseElement.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/svg/SVGUseElement.h
  Hunk #1 FAILED at 57.
  Hunk #2 succeeded at 77 (offset -1 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/svg/SVGUseElement.h.rej

Patch:       Source/core/svg/SVGUseElement.h
Index: Source/core/svg/SVGUseElement.h
diff --git a/Source/core/svg/SVGUseElement.h b/Source/core/svg/SVGUseElement.h
index
b83af14014f1ded326dfc7bf7d63a8311fb5f8e2..64ef9e714e27ff20abbf89609cc2aafc3de397c1
100644
--- a/Source/core/svg/SVGUseElement.h
+++ b/Source/core/svg/SVGUseElement.h
@@ -57,7 +57,8 @@ private:
     SVGUseElement(Document&, bool wasInsertedByParser);
 
     virtual bool isValid() const OVERRIDE { return SVGTests::isValid(); }
-    virtual bool isStructurallyExternal() const OVERRIDE { return
isExternalURIReference(hrefCurrentValue(), document()); }
+    virtual bool isStructurallyExternal() const OVERRIDE { return
!hrefCurrentValue().isNull() && isExternalURIReference(hrefCurrentValue(),
document()); }
+
     virtual bool supportsFocus() const OVERRIDE { return
hasFocusEventListeners(); }
 
     virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE;
@@ -78,7 +79,7 @@ private:
     void buildShadowAndInstanceTree(SVGElement* target);
     void detachInstance();
 
-    virtual bool haveLoadedRequiredResources() OVERRIDE { return
m_haveFiredLoadEvent; }
+    virtual bool haveLoadedRequiredResources() OVERRIDE { return
!isStructurallyExternal() || m_haveFiredLoadEvent; }
 
     virtual void finishParsingChildren() OVERRIDE;
     virtual bool selfHasRelativeLengths() const OVERRIDE;

[commit-bot: I haz the power, 2014-01-16 15:51:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ed@opera.com/134263003/540001

[commit-bot: I haz the power, 2014-01-16 19:03:39]

Retried try job too often on linux_blink for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-20 10:27:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ed@opera.com/134263003/670001

[commit-bot: I haz the power, 2014-01-20 11:40:24]

Retried try job too often on win_blink_rel for step(s) webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2014-01-20 13:09:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ed@opera.com/134263003/800001

[commit-bot: I haz the power, 2014-01-20 14:22:29]

Retried try job too often on win_blink_rel for step(s) webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[Erik Dahlström (inactive), 2014-01-20 15:58:59]

Committed patchset #7 manually as r165413 (presubmit successful).