Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1209)

Unified Diff: Source/core/svg/SVGUseElement.h

Issue 134263003: Followup fixes for bug 332066. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebased Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGDocumentExtensions.cpp ('k') | Source/core/svg/SVGUseElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGUseElement.h
diff --git a/Source/core/svg/SVGUseElement.h b/Source/core/svg/SVGUseElement.h
index 636d50feefa2b34b8d6b764ac4a2008fb75b9cdf..b68315af17855c11dbe3960594025abfb229e114 100644
--- a/Source/core/svg/SVGUseElement.h
+++ b/Source/core/svg/SVGUseElement.h
@@ -58,7 +58,8 @@ public:
private:
SVGUseElement(Document&, bool wasInsertedByParser);
- virtual bool isStructurallyExternal() const OVERRIDE { return isExternalURIReference(hrefCurrentValue(), document()); }
+ virtual bool isStructurallyExternal() const OVERRIDE { return !hrefCurrentValue().isNull() && isExternalURIReference(hrefCurrentValue(), document()); }
+
virtual bool supportsFocus() const OVERRIDE { return hasFocusEventListeners(); }
virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE;
@@ -76,8 +77,7 @@ private:
void detachInstance();
void scheduleShadowTreeRecreation();
-
- virtual bool haveLoadedRequiredResources() OVERRIDE { return m_haveFiredLoadEvent; }
+ virtual bool haveLoadedRequiredResources() OVERRIDE { return !isStructurallyExternal() || m_haveFiredLoadEvent; }
virtual void finishParsingChildren() OVERRIDE;
virtual bool selfHasRelativeLengths() const OVERRIDE;
« no previous file with comments | « Source/core/svg/SVGDocumentExtensions.cpp ('k') | Source/core/svg/SVGUseElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698