Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Unified Diff: Source/core/frame/UseCounter.cpp

Issue 1342443004: [MIGRATED] Make deprecation warnings on XHR's setRequestHeader more accurate (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@temp1288263003
Patch Set: Reflect tyoshino's comments. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | Source/core/xmlhttprequest/XMLHttpRequest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/UseCounter.cpp
diff --git a/Source/core/frame/UseCounter.cpp b/Source/core/frame/UseCounter.cpp
index 2c8a68fd0d79a79c00af42b6df260495b55e3ab1..e0a464d5fafd9aac6704a0000a1c932610dd8089 100644
--- a/Source/core/frame/UseCounter.cpp
+++ b/Source/core/frame/UseCounter.cpp
@@ -955,7 +955,10 @@ String UseCounter::deprecationMessage(Feature feature)
return "Request.context is deprecated and will be removed in M46 (see: https://www.chromestatus.com/feature/5534702526005248).";
case HeaderValueNotMatchingRFC7230:
- return "Header values not matching to RFC 7230, will be deprecated (see: https://www.chromestatus.com/feature/6457425448140800).";
+ return "Found a header value that doesn't match the field-content token production (containing invalid octets. see RFC 7230). We are experimenting whether we can throw for such header values (see: https://www.chromestatus.com/feature/6457425448140800).";
+
+ case XHRSetRequestHeaderAffectedByNormalization:
+ return "According to the Fetch Standard, setRequestHeader() must strip leading/trailing whitespaces, but it doesn't currently. We are experimenting whether we can make it conform to the spec (see: https://www.chromestatus.com/feature/6457425448140800). This script will be affected by the change.";
// Features that aren't deprecated don't have a deprecation message.
default:
« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | Source/core/xmlhttprequest/XMLHttpRequest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698