Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 1342443004: [MIGRATED] Make deprecation warnings on XHR's setRequestHeader more accurate (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@temp1288263003
Patch Set: Reflect tyoshino's comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | Source/core/xmlhttprequest/XMLHttpRequest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. All rights reserved. 2 * Copyright (C) 2012 Google, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 937 matching lines...) Expand 10 before | Expand all | Expand 10 after
948 case PrefixedPerformanceSetResourceTimingBufferSize: 948 case PrefixedPerformanceSetResourceTimingBufferSize:
949 return replacedBy("Performance.webkitSetResourceTimingBufferSize", "Perf ormance.setResourceTimingBufferSize"); 949 return replacedBy("Performance.webkitSetResourceTimingBufferSize", "Perf ormance.setResourceTimingBufferSize");
950 950
951 case PrefixedPerformanceResourceTimingBufferFull: 951 case PrefixedPerformanceResourceTimingBufferFull:
952 return replacedBy("Performance.onwebkitresourcetimingbufferfull", "Perfo rmance.onresourcetimingbufferfull"); 952 return replacedBy("Performance.onwebkitresourcetimingbufferfull", "Perfo rmance.onresourcetimingbufferfull");
953 953
954 case FetchAPIRequestContext: 954 case FetchAPIRequestContext:
955 return "Request.context is deprecated and will be removed in M46 (see: h ttps://www.chromestatus.com/feature/5534702526005248)."; 955 return "Request.context is deprecated and will be removed in M46 (see: h ttps://www.chromestatus.com/feature/5534702526005248).";
956 956
957 case HeaderValueNotMatchingRFC7230: 957 case HeaderValueNotMatchingRFC7230:
958 return "Header values not matching to RFC 7230, will be deprecated (see: https://www.chromestatus.com/feature/6457425448140800)."; 958 return "Found a header value that doesn't match the field-content token production (containing invalid octets. see RFC 7230). We are experimenting wheth er we can throw for such header values (see: https://www.chromestatus.com/featur e/6457425448140800).";
959
960 case XHRSetRequestHeaderAffectedByNormalization:
961 return "According to the Fetch Standard, setRequestHeader() must strip l eading/trailing whitespaces, but it doesn't currently. We are experimenting whet her we can make it conform to the spec (see: https://www.chromestatus.com/featur e/6457425448140800). This script will be affected by the change.";
959 962
960 // Features that aren't deprecated don't have a deprecation message. 963 // Features that aren't deprecated don't have a deprecation message.
961 default: 964 default:
962 return String(); 965 return String();
963 } 966 }
964 } 967 }
965 968
966 void UseCounter::count(CSSParserContext context, CSSPropertyID feature) 969 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)
967 { 970 {
968 ASSERT(feature >= firstCSSProperty); 971 ASSERT(feature >= firstCSSProperty);
(...skipping 28 matching lines...) Expand all
997 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 1000 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
998 { 1001 {
999 // FIXME: We may want to handle stylesheets that have multiple owners 1002 // FIXME: We may want to handle stylesheets that have multiple owners
1000 // http://crbug.com/242125 1003 // http://crbug.com/242125
1001 if (sheetContents && sheetContents->hasSingleOwnerNode()) 1004 if (sheetContents && sheetContents->hasSingleOwnerNode())
1002 return getFrom(sheetContents->singleOwnerDocument()); 1005 return getFrom(sheetContents->singleOwnerDocument());
1003 return 0; 1006 return 0;
1004 } 1007 }
1005 1008
1006 } // namespace blink 1009 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | Source/core/xmlhttprequest/XMLHttpRequest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698