Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1342393002: [Merge to M45] Don't use m_fallbackRequestForServiceWorker in ResourceLoader. (Closed)

Created:
5 years, 3 months ago by horo
Modified:
5 years, 3 months ago
Reviewers:
kinuko
CC:
blink-reviews, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org, serviceworker-reviews
Target Ref:
refs/branch-heads/chromium/2454
Project:
blink
Visibility:
Public.

Description

[Merge to M45] Don't use m_fallbackRequestForServiceWorker in ResourceLoader. We can use m_request instead. BUG=519825 Review URL: https://codereview.chromium.org/1284383003 git-svn-id: svn://svn.chromium.org/blink/trunk@200729 bbb929c8-8fbe-4397-9dbb-9b2b20218538 (cherry picked from commit 2a0ce18776f7d075d7eb91da02e130895d94e266) R=kinuko@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202321

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M Source/core/fetch/ResourceLoader.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fetch/ResourceLoader.cpp View 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
horo
kinuko@ Could you please review this?
5 years, 3 months ago (2015-09-16 02:14:35 UTC) #2
kinuko
lgtm.
5 years, 3 months ago (2015-09-16 02:19:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1342393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1342393002/1
5 years, 3 months ago (2015-09-16 04:06:22 UTC) #5
horo
5 years, 3 months ago (2015-09-16 04:08:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 202321 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698