Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1284383003: Don't use m_fallbackRequestForServiceWorker in ResourceLoader. (Closed)

Created:
5 years, 4 months ago by horo
Modified:
5 years, 4 months ago
Reviewers:
kinuko, yhirano
CC:
blink-reviews, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't use m_fallbackRequestForServiceWorker in ResourceLoader. We can use m_request instead. BUG=519825 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200729

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M Source/core/fetch/ResourceLoader.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fetch/ResourceLoader.cpp View 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
horo
yhirano@ Could you please review this?
5 years, 4 months ago (2015-08-14 09:20:34 UTC) #2
yhirano
lgtm
5 years, 4 months ago (2015-08-18 08:49:06 UTC) #3
horo
kinuko@ Could you please review this?
5 years, 4 months ago (2015-08-18 09:32:28 UTC) #5
kinuko
lgtm
5 years, 4 months ago (2015-08-18 11:24:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284383003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284383003/1
5 years, 4 months ago (2015-08-18 13:57:55 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 15:15:44 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200729

Powered by Google App Engine
This is Rietveld 408576698