components/html_viewer/BUILD.gn - Issue 1342293002: Move `gn check` into the `generate_build_files` step.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/html_viewer/BUILD.gn

Issue 1342293002: Move `gn check` into the `generate_build_files` step. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: back out installer changes, do not check //chrome/installer Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/html_viewer/BUILD.gn

diff --git a/components/html_viewer/BUILD.gn b/components/html_viewer/BUILD.gn

index 6ce7625db42591644ccc2ae9c0856618a6a24951..3c6cb37a7b77b229f8dbaa5db27d350b4e09639a 100644

--- a/components/html_viewer/BUILD.gn

+++ b/components/html_viewer/BUILD.gn

@@ -190,6 +190,7 @@ source_set("lib") {

"//ui/mojo/init",

"//ui/native_theme",

"//url",

+ "//v8",

]

public_deps = [

@@ -221,6 +222,7 @@ mojo_native_application("html_viewer") {

deps = [

":lib",

":pak",

+ "//base",

"//mojo/application/public/cpp:sources",

"//third_party/mojo/src/mojo/public/c/system:for_shared_library",

]

« no previous file with comments | « .gn ('k') | components/os_crypt/BUILD.gn » ('j') | no next file with comments »