Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1342243003: [turbofan] Greedy: small fix in groupping algo. (Closed)

Created:
5 years, 3 months ago by Mircea Trofin
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, Jim Stichnoth, jvoung (off chromium)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Greedy: small fix in groupping algo. This is a performance bug, not a functional bug: we were losing grouping opportunities. BUG= Committed: https://crrev.com/bd8c6ab0423ead70b5269d29a630c57a961a0578 Cr-Commit-Position: refs/heads/master@{#30776}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/greedy-allocator.cc View 2 chunks +1 line, -1 line 1 comment Download

Messages

Total messages: 7 (2 generated)
Mircea Trofin
5 years, 3 months ago (2015-09-16 20:03:10 UTC) #2
Jarin
lgtm https://codereview.chromium.org/1342243003/diff/20001/src/compiler/greedy-allocator.cc File src/compiler/greedy-allocator.cc (right): https://codereview.chromium.org/1342243003/diff/20001/src/compiler/greedy-allocator.cc#newcode181 src/compiler/greedy-allocator.cc:181: groupper.clear(); nit: groupper should be with single p.
5 years, 3 months ago (2015-09-16 21:28:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1342243003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1342243003/20001
5 years, 3 months ago (2015-09-16 21:41:35 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-16 21:43:24 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 21:43:46 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/bd8c6ab0423ead70b5269d29a630c57a961a0578
Cr-Commit-Position: refs/heads/master@{#30776}

Powered by Google App Engine
This is Rietveld 408576698