Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: src/compiler/greedy-allocator.cc

Issue 1342243003: [turbofan] Greedy: small fix in groupping algo. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/greedy-allocator.cc
diff --git a/src/compiler/greedy-allocator.cc b/src/compiler/greedy-allocator.cc
index acd4333954a3b5a7b129708af7c13f0b53deafdc..a0fede65f532dba5fdf27a2c2ba9fb15141d8255 100644
--- a/src/compiler/greedy-allocator.cc
+++ b/src/compiler/greedy-allocator.cc
@@ -178,6 +178,7 @@ void GreedyAllocator::PreallocateFixedRanges() {
void GreedyAllocator::GroupLiveRanges() {
CoalescedLiveRanges groupper(local_zone());
for (TopLevelLiveRange* range : data()->live_ranges()) {
+ groupper.clear();
Jarin 2015/09/16 21:28:00 nit: groupper should be with single p.
// Skip splinters, because we do not want to optimize for them, and moves
// due to assigning them to different registers occur in deferred blocks.
if (!CanProcessRange(range) || range->IsSplinter() || !range->is_phi()) {
@@ -196,7 +197,6 @@ void GreedyAllocator::GroupLiveRanges() {
// Populate the groupper.
if (range->group() == nullptr) {
- groupper.clear();
groupper.AllocateRange(range);
} else {
for (LiveRange* member : range->group()->ranges()) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698