Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 134203004: Temporary fix for bad hit testing of tab close button (Closed)

Created:
6 years, 11 months ago by sky
Modified:
6 years, 11 months ago
Reviewers:
msw, sadrul, tdanderson
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Temporary fix for bad hit testing of tab close button The problem is the close button ends up saying it has a hit test mask, but returns an empty hit test mask. The code was checking for containment, when it should be checking for intersection. My fix isn't ideal, we really need to return the intersection, but this should be good for now. BUG=332334 TEST=see bug R=msw@chromium.org, sadrul@chromium.org, tdanderson@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246686

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/views/tabs/tab.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
sky
6 years, 11 months ago (2014-01-23 16:39:33 UTC) #1
sadrul
lgtm
6 years, 11 months ago (2014-01-23 16:40:55 UTC) #2
msw
This works for me locally with Tahoma 17 on Win Classic theme, LGTM.
6 years, 11 months ago (2014-01-23 18:08:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/134203004/1
6 years, 11 months ago (2014-01-23 18:21:31 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=194046
6 years, 11 months ago (2014-01-23 19:53:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/134203004/1
6 years, 11 months ago (2014-01-23 20:18:29 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-23 21:13:47 UTC) #7
Message was sent while issue was closed.
Change committed as 246686

Powered by Google App Engine
This is Rietveld 408576698