Temporary fix for bad hit testing of tab close button

chrome/browser/ui/views/tabs/tab.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/tabs/tab.h"
 
 #include <limits>
 
 #include "base/command_line.h"
 #include "base/debug/alias.h"
@@ skipping 407 matching lines @@
 
     gfx::Rect button_bounds(GetContentsBounds());
     button_bounds.set_x(GetMirroredXForRect(button_bounds));
     gfx::RectF tab_bounds_f(gfx::SkRectToRectF(tab_mask.getBounds()));
     views::View::ConvertRectToTarget(tab_, this, &tab_bounds_f);
     gfx::Rect tab_bounds = gfx::ToEnclosingRect(tab_bounds_f);
 
     // If the button is hidden behind another tab, the hit test mask is empty.
     // Otherwise set the hit test mask to be the contents bounds.
     path->reset();
-    if (tab_bounds.Contains(button_bounds)) {
+    if (tab_bounds.Intersects(button_bounds)) {
       // Include the padding in the hit test mask for touch events.
       if (source == HIT_TEST_SOURCE_TOUCH)
         button_bounds = GetLocalBounds();
 
+      // TODO: this isn't quite right, really need to intersect the two regions.
       path->addRect(RectToSkRect(button_bounds));
     }
   }
 
   virtual const char* GetClassName() const OVERRIDE {
     return kTabCloseButtonName;
   }
 
  private:
   Tab* tab_;
@@ skipping 1321 matching lines @@
                          const gfx::ImageSkia& image) {
   DCHECK_NE(scale_factor, ui::SCALE_FACTOR_NONE);
   ImageCacheEntry entry;
   entry.resource_id = resource_id;
   entry.scale_factor = scale_factor;
   entry.image = image;
   image_cache_->push_front(entry);
   if (image_cache_->size() > kMaxImageCacheSize)
     image_cache_->pop_back();
 }