[heap] Scalable slots buffer for parallel compaction.

[heap] Scalable slots buffer for parallel compaction.

BUG=chromium:524425
LOG=N

Committed: https://crrev.com/3eda099c1b57cf688a9ce93f666d4c6807a495d5
Cr-Commit-Position: refs/heads/master@{#30800}

[Hannes Payer (out of office), 2015-09-15 17:10:38]

hpayer@chromium.org changed reviewers:
+ mlippautz@chromium.org

[Michael Lippautz, 2015-09-16 11:15:00]

Cool simplification! Let's wait for parallel compaction to land.

https://codereview.chromium.org/1341973003/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1341973003/diff/20001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:490: base::LockGuard<base::Mutex> lock_guard(
Suggestion: Can we add a private method on MarkCompactCollector that safely adds
local buffer, e.g. AddEvacuationSlotBufferSynchronized(..) (if we use such a
suffix).

[Hannes Payer (out of office), 2015-09-16 14:54:10]

https://codereview.chromium.org/1341973003/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1341973003/diff/20001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:490: base::LockGuard<base::Mutex> lock_guard(
On 2015/09/16 11:14:59, Michael Lippautz wrote:
> Suggestion: Can we add a private method on MarkCompactCollector that safely
adds
> local buffer, e.g. AddEvacuationSlotBufferSynchronized(..) (if we use such a
> suffix).

Done.

[Michael Lippautz, 2015-09-17 12:17:25]

lgtm % rebase

https://codereview.chromium.org/1341973003/diff/40001/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):

https://codereview.chromium.org/1341973003/diff/40001/src/heap/mark-compact.h...
src/heap/mark-compact.h:775: // evacuation_slots_buffers_mutex_ lock and adds
its slots buffer to the
Update comment, as the task uses AddEvacuationSlotsbufferSynchronized

[Hannes Payer (out of office), 2015-09-17 13:08:55]

https://codereview.chromium.org/1341973003/diff/40001/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):

https://codereview.chromium.org/1341973003/diff/40001/src/heap/mark-compact.h...
src/heap/mark-compact.h:775: // evacuation_slots_buffers_mutex_ lock and adds
its slots buffer to the
On 2015/09/17 12:17:25, Michael Lippautz wrote:
> Update comment, as the task uses AddEvacuationSlotsbufferSynchronized

Done.

[Hannes Payer (out of office), 2015-09-17 13:13:16]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2015-09-17 13:13:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/1341973003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-09-17 13:13:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341973003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341973003/60001

[commit-bot: I haz the power, 2015-09-17 13:38:19]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-17 13:38:43]

Patchset 4 (id:??) landed as
https://crrev.com/3eda099c1b57cf688a9ce93f666d4c6807a495d5
Cr-Commit-Position: refs/heads/master@{#30800}