Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Unified Diff: src/heap/mark-compact.h

Issue 1341973003: [heap] Scalable slots buffer for parallel compaction. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/mark-compact.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/mark-compact.h
diff --git a/src/heap/mark-compact.h b/src/heap/mark-compact.h
index 3e65a0e7d500d732a4ad374ad3393ae746649044..6fc5dbba6206421feba3dab05b972d7331c771e8 100644
--- a/src/heap/mark-compact.h
+++ b/src/heap/mark-compact.h
@@ -427,10 +427,13 @@ class MarkCompactCollector {
void UpdateSlotsRecordedIn(SlotsBuffer* buffer);
void MigrateObject(HeapObject* dst, HeapObject* src, int size,
- AllocationSpace to_old_space);
+ AllocationSpace to_old_space,
+ SlotsBuffer** evacuation_slots_buffer);
- void MigrateObjectTagged(HeapObject* dst, HeapObject* src, int size);
- void MigrateObjectMixed(HeapObject* dst, HeapObject* src, int size);
+ void MigrateObjectTagged(HeapObject* dst, HeapObject* src, int size,
+ SlotsBuffer** evacuation_slots_buffer);
+ void MigrateObjectMixed(HeapObject* dst, HeapObject* src, int size,
+ SlotsBuffer** evacuation_slots_buffer);
void MigrateObjectRaw(HeapObject* dst, HeapObject* src, int size);
bool TryPromoteObject(HeapObject* object, int object_size);
@@ -566,8 +569,6 @@ class MarkCompactCollector {
SlotsBuffer* migration_slots_buffer_;
- base::Mutex migration_slots_buffer_mutex_;
-
// Finishes GC, performs heap verification if enabled.
void Finish();
@@ -716,9 +717,15 @@ class MarkCompactCollector {
void EvacuateNewSpace();
- bool EvacuateLiveObjectsFromPage(Page* p, PagedSpace* target_space);
+ bool EvacuateLiveObjectsFromPage(Page* p, PagedSpace* target_space,
+ SlotsBuffer** evacuation_slots_buffer);
+
+ void AddEvacuationSlotsBufferSynchronized(
+ SlotsBuffer* evacuation_slots_buffer);
+
+ void EvacuatePages(CompactionSpaceCollection* compaction_spaces,
+ SlotsBuffer** evacuation_slots_buffer);
- void EvacuatePages(CompactionSpaceCollection* compaction_spaces);
void EvacuatePagesInParallel();
int NumberOfParallelCompactionTasks() {
@@ -746,13 +753,16 @@ class MarkCompactCollector {
void ParallelSweepSpaceComplete(PagedSpace* space);
// Updates store buffer and slot buffer for a pointer in a migrating object.
- void RecordMigratedSlot(Object* value, Address slot);
+ void RecordMigratedSlot(Object* value, Address slot,
+ SlotsBuffer** evacuation_slots_buffer);
// Adds the code entry slot to the slots buffer.
- void RecordMigratedCodeEntrySlot(Address code_entry, Address code_entry_slot);
+ void RecordMigratedCodeEntrySlot(Address code_entry, Address code_entry_slot,
+ SlotsBuffer** evacuation_slots_buffer);
// Adds the slot of a moved code object.
- void RecordMigratedCodeObjectSlot(Address code_object);
+ void RecordMigratedCodeObjectSlot(Address code_object,
+ SlotsBuffer** evacuation_slots_buffer);
#ifdef DEBUG
friend class MarkObjectVisitor;
@@ -771,6 +781,14 @@ class MarkCompactCollector {
List<Page*> evacuation_candidates_;
+ // The evacuation_slots_buffers_ are used by the compaction threads.
+ // When a compaction task finishes, it uses
+ // AddEvacuationSlotsbufferSynchronized to adds its slots buffer to the
+ // evacuation_slots_buffers_ list using the evacuation_slots_buffers_mutex_
+ // lock.
+ base::Mutex evacuation_slots_buffers_mutex_;
+ List<SlotsBuffer*> evacuation_slots_buffers_;
+
base::SmartPointer<FreeList> free_list_old_space_;
base::SmartPointer<FreeList> free_list_code_space_;
base::SmartPointer<FreeList> free_list_map_space_;
« no previous file with comments | « no previous file | src/heap/mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698