Create a component for SSL error handling

components/ssl_errors/ssl_error_info.h

Index: components/ssl_errors/ssl_error_info.h
diff --git a/chrome/browser/ssl/ssl_error_info.h b/components/ssl_errors/ssl_error_info.h
similarity index 82%
rename from chrome/browser/ssl/ssl_error_info.h
rename to components/ssl_errors/ssl_error_info.h
index 0ffd5539826ccd56f3d17cde61933dd43636c0f9..308d2a2f7337677586307afb44296502da571528 100644
--- a/chrome/browser/ssl/ssl_error_info.h
+++ b/components/ssl_errors/ssl_error_info.h
@@ -1,9 +1,9 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_SSL_SSL_ERROR_INFO_H_
-#define CHROME_BROWSER_SSL_SSL_ERROR_INFO_H_
+#ifndef COMPONENTS_SSL_ERRORS_SSL_ERROR_INFO_H_
+#define COMPONENTS_SSL_ERRORS_SSL_ERROR_INFO_H_
 
 #include <string>
 #include <vector>
@@ -14,6 +14,8 @@
 
 class GURL;
 
+namespace ssl_errors {
+
 // This class describes an error that happened while showing a page over SSL.
 // An SSLErrorInfo object only exists on the UI thread and only contains
 // information about an error (type of error and text details).
@@ -53,10 +55,11 @@ class SSLErrorInfo {
   // |cert_status|.  Returns the number of errors found.
   // Callers only interested in the error count can pass NULL for |errors|.
   // TODO(wtc): Document |cert_id| and |url| arguments.
-  static void GetErrorsForCertStatus(int cert_id,
-                                     net::CertStatus cert_status,
-                                     const GURL& url,
-                                     std::vector<SSLErrorInfo>* errors);
+  static void GetErrorsForCertStatus(

[estark, 2015/09/15 22:37:28]

While you're here, you could document the |cert| parameter and delete the
(probably-very-old) TODO on the line above.

[felt, 2015/09/16 14:41:53]

Done.

+      const scoped_refptr<net::X509Certificate> cert,

[Ryan Sleevi, 2015/09/16 00:21:08]

This should either be const-ref (ideal if you don't take ownership) or non-const
by-value (if and only if you're using .Pass() semantics to transfer 'ownership'
of the reference count)

the const-value just means extra refcount churn.

[felt, 2015/09/16 14:41:53]

Done.

+      net::CertStatus cert_status,
+      const GURL& url,
+      std::vector<SSLErrorInfo>* errors);
 
   // A description of the error.
   const base::string16& details() const { return details_; }
@@ -72,4 +75,6 @@ class SSLErrorInfo {
   base::string16 short_description_;
 };
 
-#endif  // CHROME_BROWSER_SSL_SSL_ERROR_INFO_H_
+}  // namespace ssl_errors
+
+#endif  // COMPONENTS_SSL_ERRORS_SSL_ERROR_INFO_H_