Create a component for SSL error handling

components/ssl_errors/ssl_error_info.h

-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_SSL_SSL_ERROR_INFO_H_
-#define CHROME_BROWSER_SSL_SSL_ERROR_INFO_H_
+#ifndef COMPONENTS_SSL_ERRORS_SSL_ERROR_INFO_H_
+#define COMPONENTS_SSL_ERRORS_SSL_ERROR_INFO_H_
 
 #include <string>
 #include <vector>
 
 #include "base/strings/string16.h"
 #include "net/cert/cert_status_flags.h"
 #include "net/cert/x509_certificate.h"
 
 class GURL;
 
+namespace ssl_errors {
+
 // This class describes an error that happened while showing a page over SSL.
 // An SSLErrorInfo object only exists on the UI thread and only contains
 // information about an error (type of error and text details).
 // Note no DISALLOW_COPY_AND_ASSIGN as we want the copy constructor.
 class SSLErrorInfo {

[estark, 2015/09/15 22:37:28]

Similar to what we did with cert reporting, did you consider making this
ssl_errors::ErrorInfo or something shorter like that?

[felt, 2015/09/16 14:41:53]

When we had that last discussion, Colin advocated against dropping the name
prefix if the resulting class name is very generic. I thought "ErrorInfo" might
be too generic so decided against renaming it. WDYT?

[estark, 2015/09/16 15:01:07]

Seems reasonable. I would personally find ssl_errors::Info too generic but
ssl_errors::ErrorInfo descriptive enough, but I think it's just a subjective
preference. I'm fine with leaving it as is.

[felt, 2015/09/16 20:28:07]

since blundell doesn't mind, I've updated it to be ssl_errors::ErrorInfo

  public:
   // This enum is being histogrammed; please only add new values at the end.
   enum ErrorType {
     CERT_COMMON_NAME_INVALID = 0,
     CERT_DATE_INVALID,
     CERT_AUTHORITY_INVALID,
     CERT_CONTAINS_ERRORS,
     CERT_NO_REVOCATION_MECHANISM,
     CERT_UNABLE_TO_CHECK_REVOCATION,
     CERT_REVOKED,
@@ skipping 14 matching lines @@
   static ErrorType NetErrorToErrorType(int net_error);
 
   static SSLErrorInfo CreateError(ErrorType error_type,
                                   net::X509Certificate* cert,
                                   const GURL& request_url);
 
   // Populates the specified |errors| vector with the errors contained in
   // |cert_status|.  Returns the number of errors found.
   // Callers only interested in the error count can pass NULL for |errors|.
   // TODO(wtc): Document |cert_id| and |url| arguments.
-  static void GetErrorsForCertStatus(int cert_id,
-                                     net::CertStatus cert_status,
-                                     const GURL& url,
-                                     std::vector<SSLErrorInfo>* errors);
+  static void GetErrorsForCertStatus(

[estark, 2015/09/15 22:37:28]

While you're here, you could document the |cert| parameter and delete the
(probably-very-old) TODO on the line above.

[felt, 2015/09/16 14:41:53]

Done.

+      const scoped_refptr<net::X509Certificate> cert,

[Ryan Sleevi, 2015/09/16 00:21:08]

This should either be const-ref (ideal if you don't take ownership) or non-const
by-value (if and only if you're using .Pass() semantics to transfer 'ownership'
of the reference count)

the const-value just means extra refcount churn.

[felt, 2015/09/16 14:41:53]

Done.

+      net::CertStatus cert_status,
+      const GURL& url,
+      std::vector<SSLErrorInfo>* errors);
 
   // A description of the error.
   const base::string16& details() const { return details_; }
 
   // A short message describing the error (1 line).
   const base::string16& short_description() const { return short_description_; }
 
  private:
   SSLErrorInfo(const base::string16& details,
                const base::string16& short_description);
 
   base::string16 details_;
   base::string16 short_description_;
 };
 
-#endif  // CHROME_BROWSER_SSL_SSL_ERROR_INFO_H_
+}  // namespace ssl_errors
+
+#endif  // COMPONENTS_SSL_ERRORS_SSL_ERROR_INFO_H_