Issue 1341913002: Merge to XFA: Get CJS_RuntimeFactory out of CJS_GlobalData management.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1341913002: Merge to XFA: Get CJS_RuntimeFactory out of CJS_GlobalData management. (Closed)

Created:
5 years, 3 months ago by Tom Sepez

Modified:
5 years, 3 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

More Reviews

Description

Merge to XFA: Get CJS_RuntimeFactory out of CJS_GlobalData management. (cherry picked from commit 9a817f092e6800e9338b41acf4ea0416b6ad4467) Original Review URL: https://codereview.chromium.org/1338993005 . Small manual merge in fpdfsdk/src/javascript/JS_GlobalData.cpp fpdfsdk/src/javascript/global.cpp TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/f458362c167f29f37301f48b08eb8d916e69d40b

Patch Set 1 #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -55 lines)			Patch
M	fpdfsdk/include/javascript/IJavaScript.h	View	2 chunks	+5 lines, -12 lines	0 comments	Download
M	fpdfsdk/include/javascript/JS_GlobalData.h	View	3 chunks	+8 lines, -3 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_GlobalData.cpp	View	2 chunks	+23 lines, -17 lines	1 comment	Download
M	fpdfsdk/src/javascript/JS_Runtime.cpp	View	2 chunks	+0 lines, -20 lines	0 comments	Download
M	fpdfsdk/src/javascript/global.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Tom Sepez

Committed patchset #1 (id:1) manually as f458362c167f29f37301f48b08eb8d916e69d40b (presubmit successful).

5 years, 3 months ago (2015-09-14 22:06:57 UTC) #2

Lei Zhang

5 years, 3 months ago (2015-09-14 22:10:05 UTC) #3

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/1341913002/diff/1/fpdfsdk/src/javascript/JS_G...
File fpdfsdk/src/javascript/JS_GlobalData.cpp (right):

https://codereview.chromium.org/1341913002/diff/1/fpdfsdk/src/javascript/JS_G...
fpdfsdk/src/javascript/JS_GlobalData.cpp:121: : m_pApp(pApp), m_RefCount(0) {
Huh, didn't notice the non-XFA version not using the passed-in argument, but ok.

Expand Messages | Collapse Messages