Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: fpdfsdk/src/javascript/global.cpp

Issue 1341913002: Merge to XFA: Get CJS_RuntimeFactory out of CJS_GlobalData management. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: fpdfsdk/src/javascript/global.cpp
diff --git a/fpdfsdk/src/javascript/global.cpp b/fpdfsdk/src/javascript/global.cpp
index 07709129feb8955be8990aa7d242996767e0addd..e87db8c7a0f7d7233a862512be63664522cff74d 100644
--- a/fpdfsdk/src/javascript/global.cpp
+++ b/fpdfsdk/src/javascript/global.cpp
@@ -109,13 +109,12 @@ JSGlobalAlternate::JSGlobalAlternate(CJS_Object* pJSObject)
JSGlobalAlternate::~JSGlobalAlternate() {
DestroyGlobalPersisitentVariables();
- CPDFXFA_App::GetInstance()->GetRuntimeFactory()->ReleaseGlobalData();
+ m_pGlobalData->Release();
}
void JSGlobalAlternate::Initial(CPDFDoc_Environment* pApp) {
m_pApp = pApp;
- m_pGlobalData =
- CPDFXFA_App::GetInstance()->GetRuntimeFactory()->NewGlobalData(pApp);
+ m_pGlobalData = CJS_GlobalData::GetRetainedInstance(pApp);
UpdateGlobalPersistentVariables();
}
« fpdfsdk/src/javascript/JS_GlobalData.cpp ('K') | « fpdfsdk/src/javascript/JS_Runtime.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698