Media Source dispatches inband text tracks

webkit/media/webinbandtexttrackprivateclient_impl.h

Index: webkit/media/webinbandtexttrackprivateclient_impl.h
diff --git a/webkit/media/webinbandtexttrackprivateclient_impl.h b/webkit/media/webinbandtexttrackprivateclient_impl.h
new file mode 100644
index 0000000000000000000000000000000000000000..764f7aaf64a8873af090bc537a90a205f988e532
--- /dev/null
+++ b/webkit/media/webinbandtexttrackprivateclient_impl.h
@@ -0,0 +1,49 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Delegate calls from WebCore::MediaPlayerPrivate to Chrome's video player.
+// It contains Pipeline which is the actual media player pipeline, it glues
+// the media player pipeline, data source, audio renderer and renderer.
+// Pipeline would creates multiple threads and access some public methods
+// of this class, so we need to be extra careful about concurrent access of
+// methods and members.
+//
+// Other issues:
+// During tear down of the whole browser or a tab, the DOM tree may not be
+// destructed nicely, and there will be some dangling media threads trying to
+// the main thread, so we need this class to listen to destruction event of the
+// main thread and cleanup the media threads when the even is received. Also
+// at destruction of this class we will need to unhook it from destruction event
+// list of the main thread.
+
+#ifndef WEBKIT_MEDIA_WEBINANDTEXTTRACKPRIVATECLIENT_IMPL_H_
+#define WEBKIT_MEDIA_WEBINANDTEXTTRACKPRIVATECLIENT_IMPL_H_
+
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebInbandTextTrackPrivateClient.h"
+
+namespace WebCore {
+class InbandTextTrackPrivateClient;
+}
+
+namespace webkit_media {
+
+class WebInbandTextTrackPrivateClientImpl
+    : public WebKit::WebInbandTextTrackPrivateClient {
+ public:
+  WebInbandTextTrackPrivateClientImpl();
+  virtual ~WebInbandTextTrackPrivateClientImpl();
+  virtual void addWebVTTCue(WebKit::WebInbandTextTrackPrivate*,
+                            double /*start*/,
+                            double /*end*/,
+                            const WebKit::WebString& /*id*/,
+                            const WebKit::WebString& /*content*/,
+                            const WebKit::WebString& /*settings*/);
+
+ private:
+  WebCore::InbandTextTrackPrivateClient* client_;

[fgalligan1, 2013/04/02 19:38:32]

Why is this declared here? When it is declared int he base class here
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[Matthew Heaney (Chromium), 2013/04/04 04:01:52]

OBE

+};
+
+}  // namespace webkit_media
+
+#endif

[fgalligan1, 2013/04/02 19:38:32]

// WEBKIT_MEDIA_WEBINANDTEXTTRACKPRIVATECLIENT_IMPL_H_