Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: webkit/media/webinbandtexttrackprivateclient_impl.h

Issue 13419002: Media Source dispatches inband text tracks (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 // Delegate calls from WebCore::MediaPlayerPrivate to Chrome's video player.
6 // It contains Pipeline which is the actual media player pipeline, it glues
7 // the media player pipeline, data source, audio renderer and renderer.
8 // Pipeline would creates multiple threads and access some public methods
9 // of this class, so we need to be extra careful about concurrent access of
10 // methods and members.
11 //
12 // Other issues:
13 // During tear down of the whole browser or a tab, the DOM tree may not be
14 // destructed nicely, and there will be some dangling media threads trying to
15 // the main thread, so we need this class to listen to destruction event of the
16 // main thread and cleanup the media threads when the even is received. Also
17 // at destruction of this class we will need to unhook it from destruction event
18 // list of the main thread.
19
20 #ifndef WEBKIT_MEDIA_WEBINANDTEXTTRACKPRIVATECLIENT_IMPL_H_
21 #define WEBKIT_MEDIA_WEBINANDTEXTTRACKPRIVATECLIENT_IMPL_H_
22
23 #include "third_party/WebKit/Source/WebKit/chromium/public/WebInbandTextTrackPri vateClient.h"
24
25 namespace WebCore {
26 class InbandTextTrackPrivateClient;
27 }
28
29 namespace webkit_media {
30
31 class WebInbandTextTrackPrivateClientImpl
32 : public WebKit::WebInbandTextTrackPrivateClient {
33 public:
34 WebInbandTextTrackPrivateClientImpl();
35 virtual ~WebInbandTextTrackPrivateClientImpl();
36 virtual void addWebVTTCue(WebKit::WebInbandTextTrackPrivate*,
37 double /*start*/,
38 double /*end*/,
39 const WebKit::WebString& /*id*/,
40 const WebKit::WebString& /*content*/,
41 const WebKit::WebString& /*settings*/);
42
43 private:
44 WebCore::InbandTextTrackPrivateClient* client_;
fgalligan1 2013/04/02 19:38:32 Why is this declared here? When it is declared int
Matthew Heaney (Chromium) 2013/04/04 04:01:52 OBE
45 };
46
47 } // namespace webkit_media
48
49 #endif
fgalligan1 2013/04/02 19:38:32 // WEBKIT_MEDIA_WEBINANDTEXTTRACKPRIVATECLIENT_IMP
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698