Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: services/nacl/BUILD.gn

Issue 1341873002: Enabling 64-bit mojo shell to launch 32-bit child to handle nonsfi content. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Anonymous namespaces and modified target names Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | shell/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/nacl/BUILD.gn
diff --git a/services/nacl/BUILD.gn b/services/nacl/BUILD.gn
index 37f2515b7321959933eff0fd298ece9796977d34..b0589133ed4085c2d25c1b81665f17f4cfb26984 100644
--- a/services/nacl/BUILD.gn
+++ b/services/nacl/BUILD.gn
@@ -26,20 +26,51 @@ if (!is_nacl) {
data_deps = [ "//nacl_bindings:irt_mojo(//native_client/build/toolchain/nacl:irt_${target_cpu})" ]
}
- mojo_native_application("nacl_content_handler_nonsfi") {
- sources = [
- "content_handler_main_nonsfi.cc",
- ]
+ if (current_cpu == "x86") {
+ # Non-SFI NaCl can only be executed by a 32-bit process, so our
+ # content handler must be built and launched as a 32-bit process as well.
+ mojo_native_application("nacl_content_handler_nonsfi_32_bit") {
+ sources = [
+ "content_handler_main_nonsfi.cc",
+ ]
- deps = [
- "//base",
- "//mojo/application:application",
- "//mojo/application:content_handler",
- "//mojo/data_pipe_utils",
- "//mojo/message_pump",
- "//mojo/nacl:irt_mojo_nonsfi",
- "//mojo/public/cpp/application:application",
- "//native_client/src/nonsfi/loader:elf_loader",
- ]
+ deps = [
+ "//base",
+ "//mojo/application:application",
+ "//mojo/application:content_handler",
+ "//mojo/data_pipe_utils",
+ "//mojo/message_pump",
+ "//mojo/nacl:irt_mojo_nonsfi",
+ "//mojo/public/cpp/application:application",
+ "//native_client/src/nonsfi/loader:elf_loader",
+ ]
+ }
+
+ # Copy to the root build directory so that the '#!' prefix line for invoking
+ # our content handler can simply be "mojo:nacl_content_handler_nonsfi".
+ copy("nacl_content_handler_nonsfi_copy") {
+ sources = [
+ "${root_out_dir}/nacl_content_handler_nonsfi_32_bit.mojo",
+ ]
+ outputs = [
+ "${root_build_dir}/nacl_content_handler_nonsfi.mojo",
+ ]
+ deps = [
+ ":nacl_content_handler_nonsfi_32_bit",
+ ]
+ }
+ }
+}
+
+# This group serves as a 64 to 32 bit transformation for Linux. If we are
+# using a 64 bit toolchain, build the nonsfi nacl content handler as 32 bit.
+group("nacl_content_handler_nonsfi") {
+ deps = []
+ if ((target_cpu == "x64" || target_cpu == "x86") && is_linux) {
+ # The toolchain is hardcoded as 32-bit clang here -- although it must
+ # be 32 bit (for nonsfi), it assumes clang. Ideally, the toolchain would
+ # be defined as the 32 bit variant of whatever is being used (be it clang,
+ # gcc, or something else).
+ deps += [ ":nacl_content_handler_nonsfi_copy(//build/toolchain/linux:clang_x86)" ]
}
}
« no previous file with comments | « no previous file | shell/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698