Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: shell/BUILD.gn

Issue 1341873002: Enabling 64-bit mojo shell to launch 32-bit child to handle nonsfi content. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Anonymous namespaces and modified target names Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/nacl/BUILD.gn ('k') | shell/child_process_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/BUILD.gn
diff --git a/shell/BUILD.gn b/shell/BUILD.gn
index 56c6596b7a2dcf4a4bd75664c3d6463b1fad1916..42473af0d7e2b4efa92e78592284b33a40a150b8 100644
--- a/shell/BUILD.gn
+++ b/shell/BUILD.gn
@@ -83,7 +83,7 @@ if (!mojo_use_prebuilt_mojo_shell) {
"desktop/main.cc",
]
- deps = shell_common_deps
+ deps = shell_common_deps + [ ":mojo_shell_child_32_bit" ]
data_deps = shell_common_data_deps
}
@@ -105,6 +105,37 @@ if (!mojo_use_prebuilt_mojo_shell) {
"//mojo/message_pump",
]
}
+
+ if (current_cpu == "x86") {
+ # The 32-bit version of the mojo_shell_child should be accessible in the
+ # root build directory, just like the regular mojo_shell_child, so that
+ # the 32-bit version can be accessed by simply adding a suffix to the path.
+ copy("mojo_shell_child_32_bit_copy") {
+ sources = [
+ "${root_out_dir}/mojo_shell_child",
+ ]
+ outputs = [
+ "${root_build_dir}/mojo_shell_child_32",
+ ]
+ deps = [
+ ":mojo_shell_child",
+ ]
+ }
+ }
+
+ group("mojo_shell_child_32_bit") {
+ # This group is required to run any 32-bit child process.
+ deps = []
+ if ((target_cpu == "x64" || target_cpu == "x86") && is_linux) {
+ # The toolchain is hardcoded as 32-bit clang here -- although it must
+ # be 32 bit (for nonsfi), it assumes clang. Ideally, the toolchain would
+ # be defined as the 32 bit variant of whatever is being used (be it clang,
+ # gcc, or something else).
+ deps = [
+ ":mojo_shell_child_32_bit_copy(//build/toolchain/linux:clang_x86)",
+ ]
+ }
+ }
} # !mojo_use_prebuilt_mojo_shell
# Files used both by mojo_shell and mojo_shell_child (and tests).
« no previous file with comments | « services/nacl/BUILD.gn ('k') | shell/child_process_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698