Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1341793004: [Android] Save url in enhanced bookmark edit activity correctly. (Closed)

Created:
5 years, 3 months ago by Kibeom Kim (inactive)
Modified:
5 years, 3 months ago
Reviewers:
Ian Wen, newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Save url in enhanced bookmark edit activity correctly. If user edited title and url at the same time, url didn't get saved. The reason is that we save title first, then UI is refreshed by bookmark observer, which resets the url edit text to the original url. BUG=530794 Committed: https://crrev.com/edf1e4c8c1bf28d70f20570fe3a4707c5add414f Cr-Commit-Position: refs/heads/master@{#348756}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Kibeom Kim (inactive)
5 years, 3 months ago (2015-09-14 21:06:29 UTC) #2
Ian Wen
Interesting bug. lgtm.
5 years, 3 months ago (2015-09-14 22:06:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341793004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341793004/1
5 years, 3 months ago (2015-09-14 22:18:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 23:13:57 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/edf1e4c8c1bf28d70f20570fe3a4707c5add414f Cr-Commit-Position: refs/heads/master@{#348756}
5 years, 3 months ago (2015-09-14 23:14:29 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:38:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/edf1e4c8c1bf28d70f20570fe3a4707c5add414f
Cr-Commit-Position: refs/heads/master@{#348756}

Powered by Google App Engine
This is Rietveld 408576698