Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java

Issue 1341793004: [Android] Save url in enhanced bookmark edit activity correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java
index 9058dc5cf50348f4c35069829e629d7430b0754d..be7c5dc38ddea2543afb3357d594ad3b2807a944 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java
@@ -179,14 +179,16 @@ public class EnhancedBookmarkEditActivity extends EnhancedBookmarkActivityBase {
@Override
protected void onStop() {
if (mEnhancedBookmarksModel.doesBookmarkExist(mBookmarkId)) {
+ final String title = mTitleEditText.getTrimmedText();
+ final String url = mUrlEditText.getTrimmedText();
+
if (!mTitleEditText.isEmpty()) {
- mEnhancedBookmarksModel.setBookmarkTitle(
- mBookmarkId, mTitleEditText.getTrimmedText());
+ mEnhancedBookmarksModel.setBookmarkTitle(mBookmarkId, title);
}
if (!mUrlEditText.isEmpty()
&& mEnhancedBookmarksModel.getBookmarkById(mBookmarkId).isUrlEditable()) {
- String fixedUrl = UrlUtilities.fixupUrl(mUrlEditText.getTrimmedText());
+ String fixedUrl = UrlUtilities.fixupUrl(url);
if (fixedUrl != null) mEnhancedBookmarksModel.setBookmarkUrl(mBookmarkId, fixedUrl);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698