Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1341783003: Conditionally update FontSelector on invalidation. (Closed)

Created:
5 years, 3 months ago by sof
Modified:
5 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Conditionally update FontSelector on invalidation. When invalidating a FontFallbackList to use a new FontSelector, check that the new FontSelector really represents a change. Avoids needless RefPtr/Persistent churn. R=haraken BUG= Committed: https://crrev.com/c636b7e77e771119be8ba7504b4fd6e4008c80bd git-svn-id: svn://svn.chromium.org/blink/trunk@202203 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/platform/fonts/FontFallbackList.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
sof
please take a look. Following up on the churn reported in https://codereview.chromium.org/1338573003/#msg14
5 years, 3 months ago (2015-09-14 14:24:37 UTC) #2
haraken
LGTM
5 years, 3 months ago (2015-09-14 14:40:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341783003/1
5 years, 3 months ago (2015-09-14 14:43:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202203
5 years, 3 months ago (2015-09-14 15:41:59 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:32:37 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c636b7e77e771119be8ba7504b4fd6e4008c80bd

Powered by Google App Engine
This is Rietveld 408576698