Source/platform/fonts/FontFallbackList.cpp - Issue 1341783003: Conditionally update FontSelector on invalidation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/FontFallbackList.cpp

Issue 1341783003: Conditionally update FontSelector on invalidation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/fonts/FontFallbackList.cpp

diff --git a/Source/platform/fonts/FontFallbackList.cpp b/Source/platform/fonts/FontFallbackList.cpp

index d8eb999702eb9a4d9966a73bb086c4fe1a0bad31..284f6124f883c5305bc5d99b66b7b8ddc7310688 100644

--- a/Source/platform/fonts/FontFallbackList.cpp

+++ b/Source/platform/fonts/FontFallbackList.cpp

@@ -58,7 +58,8 @@ void FontFallbackList::invalidate(PassRefPtrWillBeRawPtr<FontSelector> fontSelec

m_cachedPrimarySimpleFontData = 0;

m_familyIndex = 0;

m_hasLoadingFallback = false;

- m_fontSelector = fontSelector;

+ if (m_fontSelector != fontSelector)

+ m_fontSelector = fontSelector;

m_fontSelectorVersion = m_fontSelector ? m_fontSelector->version() : 0;

m_generation = FontCache::fontCache()->generation();

m_cachingWordShaper.clear();

« no previous file with comments | « no previous file | no next file » | no next file with comments »