Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1341733003: Change times reported from io resource meta data to be milliseconds since epoch (Closed)

Created:
5 years, 3 months ago by ricow1
Modified:
5 years, 3 months ago
Reviewers:
Søren Gjesse, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change times reported from io resource meta data to be milliseconds since epoch Change tests accordingly (and add a few extra tests) Move the logic to the _IOResource class to only have one datetime and one stopwatch. R=johnmccutchan@google.com, sgjesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f3f358e5f38829f3284d7f922f2393d0803115dd

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -23 lines) Patch
M runtime/observatory/tests/service/file_service_test.dart View 1 chunk +6 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/process_service_test.dart View 3 chunks +4 lines, -0 lines 2 comments Download
M runtime/observatory/tests/service/tcp_socket_service_test.dart View 4 chunks +5 lines, -14 lines 0 comments Download
M sdk/lib/io/io_resource_info.dart View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ricow1
5 years, 3 months ago (2015-09-14 11:30:24 UTC) #1
Søren Gjesse
lgtm
5 years, 3 months ago (2015-09-14 12:37:53 UTC) #2
Cutch
lgtm with one big DBC about service protocol field names being 'dartCamelCase'. https://codereview.chromium.org/1341733003/diff/1/runtime/observatory/tests/service/process_service_test.dart File runtime/observatory/tests/service/process_service_test.dart ...
5 years, 3 months ago (2015-09-14 14:23:32 UTC) #4
ricow1
https://codereview.chromium.org/1341733003/diff/1/runtime/observatory/tests/service/process_service_test.dart File runtime/observatory/tests/service/process_service_test.dart (right): https://codereview.chromium.org/1341733003/diff/1/runtime/observatory/tests/service/process_service_test.dart#newcode97 runtime/observatory/tests/service/process_service_test.dart:97: expect(first['started_at'], greaterThan(0)); On 2015/09/14 14:23:32, Cutch wrote: > DBC- ...
5 years, 3 months ago (2015-09-14 15:57:46 UTC) #5
ricow1
5 years, 3 months ago (2015-09-15 05:42:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f3f358e5f38829f3284d7f922f2393d0803115dd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698